sbin/dhclient: fix `vendor` storage leak in parse_option_decl(..)
ClosedPublic
Actions

Authored by ngie on Mar 13 2017, 5:19 PM.

Details

Reviewers

dumbbell
bms
cem
trix_juniper.net

Commits

rS315203: sbin/dhclient: fix `vendor` storage leak in parse_option_decl(..)

Summary

sbin/dhclient: fix vendor storage leak in parse_option_decl(..)

This ensures the storage isn't leaked when non-NULL and the function
returns early, prior to the free(vendor) later on in the function.

MFC after: 1 week
Reported by: Coverity
CID: 1007111-1007113
Sponsored by: Dell EMC Isilon

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8036
Build 8219: CI src build	Jenkins
Build 8218: arc lint + arc unit

Event Timeline

ngie created this revision.Mar 13 2017, 5:19 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 13 2017, 5:19 PM

Harbormaster completed remote builds in B8035: Diff 26226.Mar 13 2017, 5:19 PM

Remove goto label; free when exiting function, prior to free(vendor) on line 757 (missed
when reviewing the code previously).

ngie edited the summary of this revision. (Show Details)Mar 13 2017, 5:30 PM

cem accepted this revision.Mar 13 2017, 5:37 PM

This revision is now accepted and ready to land.Mar 13 2017, 5:37 PM

Closed by commit rS315203: sbin/dhclient: fix `vendor` storage leak in parse_option_decl(..) (authored by ngie). · Explain WhyMar 13 2017, 5:45 PM

This revision was automatically updated to reflect the committed changes.

ngie mentioned this in rS315203: sbin/dhclient: fix `vendor` storage leak in parse_option_decl(..).

Harbormaster completed remote builds in B8035: Diff 26226.Mar 13 2017, 6:12 PM

Harbormaster completed remote builds in B8036: Diff 26227.Mar 13 2017, 6:54 PM

Revision Contents
Changeset List

Path

Size

sbin/

dhclient/

clparse.c

3 lines

Diff 26227

View Options

sbin/dhclient: fix `vendor` storage leak in parse_option_decl(..)ClosedPublicActions