Page MenuHomeFreeBSD

Add a number of binutils replacements from the elftoolchain project
ClosedPublic

Authored by emaste on Nov 25 2014, 2:48 PM.
Tags
None
Referenced Files
F105908022: D1224.diff
Sun, Dec 22, 11:13 AM
Unknown Object (File)
Tue, Dec 10, 2:54 AM
Unknown Object (File)
Tue, Dec 3, 7:32 AM
Unknown Object (File)
Thu, Nov 28, 7:04 AM
Unknown Object (File)
Nov 18 2024, 6:07 PM
Unknown Object (File)
Nov 18 2024, 1:45 PM
Unknown Object (File)
Nov 18 2024, 1:44 PM
Unknown Object (File)
Nov 1 2024, 10:29 PM
Subscribers

Details

Summary
  • addr2line
  • elfcopy / strip / mcs
  • nm
  • size
  • strings

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste retitled this revision from to Add libelftc and elfcopy/strip/mcs from elftoolchain.
emaste updated this object.

Right now this will install strip as bsdstrip, along with elfcopy and mcs. We can probably do without the latter.

My goal would be to bring in later on size, strings, and nm, and add a knob to use them instead of the GNU counterparts.

lib/libelftc/elftc_version.c
7 ↗(On Diff #2542)

Will change to "r3076"

bapt edited edge metadata.
bapt added inline comments.
contrib/elftoolchain/elfcopy/Makefile
12 ↗(On Diff #2542)

Should be LIBADD= elf elftc

15 ↗(On Diff #2542)

Should be LIBADD+= archive

This revision is now accepted and ready to land.Nov 25 2014, 3:51 PM
contrib/elftoolchain/elfcopy/Makefile
12 ↗(On Diff #2542)

Ah, this is the contrib Makefile that's not used. I could strip it out of contrib perhaps to avoid confusion, but I think my preference is to leave vendor imports as-is.

Have a look at the lib/libelftc/Makefile.

I forgot to cancel my inline comments, but yes I saw after commenting inline :)

emaste edited edge metadata.
  • Update libelftc to SVN r3076
  • Update elfcopy to upstream SVN r3076
  • Track libarchive API change
  • Fix elftoolchain tools build on FreeBSD
  • Remove non-FreeBSD bits for now
  • Build infrastructure for elftoolchain tools
This revision now requires review to proceed.Nov 27 2014, 9:20 PM
usr.bin/elfcopy/Makefile
20 ↗(On Diff #2568)

not sure it's worth installing mcs
also bsdstrip.1 should be strip.1, this is an error in my rebasing

emaste retitled this revision from Add libelftc and elfcopy/strip/mcs from elftoolchain to Add a number of binutils replacements from the elftoolchain project.Nov 27 2014, 9:26 PM
emaste updated this object.
emaste edited edge metadata.
emaste added a subscriber: dim.
usr.bin/addr2line/Makefile
16–17 ↗(On Diff #2568)

Seems unnecessary

If libelftc always implies libelf then you could just:

DPADD_elftc= ${DPADD_elf}
LDADD_elftc= ${LDADD_elf}

in src.libnames.mk

So everything linking to elftc will link to elf automatically and they only needs
LIBADD= elftc

Don't know it is worth or not in your case :)

lib/libelftc/Makefile
28 ↗(On Diff #2568)

LIBADD= elf
but do you really need that given you are building an internallib?

30 ↗(On Diff #2568)

Should be NO_MAN=yes

It looks like PR191587 https://bugs.freebsd.org/191587 is fixed with this change.

emaste updated this object.

Update with some feedback from bapt@

emaste updated this revision to Diff 2586.

Closed by commit rS275373 (authored by @emaste).