Differential D9694

sys: replace most zeros with NULL for pointers.
ClosedPublic
Actions

Authored by pfg on Feb 20 2017, 6:26 PM.

Tags

None

Referenced Files

	F84287403: D9694.id25438.diff
	Tue, May 21, 9:18 PM

	F84258114: D9694.id25479.diff
	Tue, May 21, 1:50 PM

	F84256007: D9694.id.diff
	Tue, May 21, 1:04 PM

	Unknown Object (File)
	Wed, May 15, 7:54 PM

	Unknown Object (File)
	Wed, May 8, 3:59 PM

	Unknown Object (File)
	Wed, May 8, 2:55 PM

	Unknown Object (File)
	Wed, May 1, 10:23 AM

	Unknown Object (File)
	Feb 22 2024, 2:12 PM

View All 43 Files

Subscribers

Details

Reviewers

cem
imp

Commits

rS314068: sys: Replace zero with NULL for pointers.

Summary

These were caught by coccinelle.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pfg updated this revision to Diff 25438.Feb 20 2017, 6:26 PM

pfg retitled this revision from to sys: replace most zeros with NULL for pointers..

pfg updated this object.

pfg edited the test plan for this revision. (Show Details)

pfg added a reviewer: imp.

Herald added subscribers: ae, delphij. · View Herald TranscriptFeb 20 2017, 6:26 PM

pfg added a reviewer: cem.Feb 21 2017, 12:33 AM

Remove some changes, at least one false positive.

These are all correct and represent better style than the previous code. It won't change the semantics of the code even on architectures where a null-pointer has bits set because comparison to or assignment to 0 is special in 'C'. Since it improves the style, and doesn't change the semantics, this is a good change.

This revision is now accepted and ready to land.Feb 21 2017, 6:54 PM

delphij added inline comments.Feb 21 2017, 7:55 PM

sys/libkern/iconv_xlat16.c
271 ↗	(On Diff #25479)	Maybe '\0' instead of NUL?

pfg added inline comments.Feb 22 2017, 2:04 AM

sys/libkern/iconv_xlat16.c
271 ↗	(On Diff #25479)	Hmm.. I thought I had reverted this change. Yes, thanks! '\0' should work. I will commit it after testing.

Closed by commit rS314068: sys: Replace zero with NULL for pointers. (authored by pfg). · Explain WhyFeb 22 2017, 2:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

amd64/

12 lines

2 lines

boot/

common/

2 lines

efi/

libefi/

4 lines

fdt/

2 lines

ficl/

2 lines

kshim/

2 lines

ofw/

libofw/

2 lines

sparc64/

loader/

2 lines

userboot/

userboot/

userboot_disk.c

4 lines

zfs/

2 lines

6 lines

libkern/

2 lines

mips/

atheros/

ar531x/

2 lines

net/

2 lines

if_iso88025subr.c

2 lines

4 lines

netpfil/

ipfw/

ip_fw_sockopt.c

2 lines

Diff 25504

head/sys/amd64/amd64/db_disasm.c

Loading...

head/sys/amd64/amd64/pmap.c

Loading...

head/sys/boot/common/md.c

Loading...

head/sys/boot/efi/libefi/efinet.c

Loading...

head/sys/boot/fdt/fdt_overlay.c

Loading...

head/sys/boot/ficl/ficl.c

Loading...

head/sys/boot/kshim/bsd_kernel.c

Loading...

head/sys/boot/ofw/libofw/ofw_memory.c

Loading...

head/sys/boot/sparc64/loader/main.c

Loading...

head/sys/boot/userboot/userboot/userboot_disk.c

Loading...

head/sys/boot/zfs/zfs.c

Loading...

head/sys/boot/zfs/zfsimpl.c

Loading...

head/sys/libkern/iconv_xlat16.c

Loading...

head/sys/mips/atheros/ar531x/apb.c

Loading...

head/sys/net/if_fddisubr.c

Loading...

head/sys/net/if_iso88025subr.c

Loading...

head/sys/net/iflib.c

Loading...

head/sys/netpfil/ipfw/ip_fw_sockopt.c

Loading...