fix memory leak in 'finger'
ClosedPublic
Actions

Authored by trix_juniper.net on Feb 17 2017, 5:50 PM.

Tags

None

Referenced Files

	F153326908: D9652.diff
	Mon, Apr 20, 12:16 PM

	Unknown Object (File)
	Sun, Apr 19, 6:53 PM

	Unknown Object (File)
	Fri, Apr 17, 8:50 PM

	Unknown Object (File)
	Wed, Apr 15, 5:48 AM

	Unknown Object (File)
	Tue, Apr 14, 5:32 PM

	Unknown Object (File)
	Tue, Apr 14, 1:41 PM

	Unknown Object (File)
	Mon, Apr 13, 10:27 PM

	Unknown Object (File)
	Mon, Apr 13, 12:09 PM

View All Files

Subscribers

imp

Details

Reviewers

stevek
ed

Commits

rS319903: The variable nargv is allocated but never freed, so free it when the it

Summary

the variable nargv is allocated but never freed, so free it when the it is no longer used

Test Plan

Run clang's scan-build before the fix to find the problem, run after to verify fixed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

trix_juniper.net updated this revision to Diff 25319.Feb 17 2017, 5:50 PM

trix_juniper.net retitled this revision from to fix memory leak in 'finger'.

trix_juniper.net updated this object.

trix_juniper.net edited the test plan for this revision. (Show Details)

trix_juniper.net added reviewers: stevek, ed.

trix_juniper.net set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2017, 5:50 PM

ed accepted this revision.Feb 17 2017, 5:53 PM

ed edited edge metadata.

This revision is now accepted and ready to land.Feb 17 2017, 5:53 PM

Closed by commit rS319903: The variable nargv is allocated but never freed, so free it when the it (authored by stevek). · Explain WhyJun 13 2017, 3:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.bin/

finger/

finger.c

1 line

Diff 25319

View Options

fix memory leak in 'finger'ClosedPublicActions