First version of a port for Ceph to FreeBSD.
This is based on development code.
Once a new major version is released (Luminous),
there will also be a ceph-port based on the release schedule of Ceph.
Differential D9584
First version of net/ceph-devel wjw_digiware.nl on Feb 14 2017, 1:50 AM. Authored by Tags None Referenced Files
Subscribers
Details
First version of a port for Ceph to FreeBSD. Once a new major version is released (Luminous),
Diff Detail
Event TimelineThere are a very large number of changes, so older changes are hidden. Show Older Changes
Comment Actions Poudriere still shows a lot of orphaned files that aren't present in pkg-plist. If it's your intentional not to install these things, you can either modify the build to not build or not install them, or you can simply delete them from the STAGEDIR during the post-install target. Examples: Error: Orphaned: bin/ceph_tpbench Error: Orphaned: %%PYTHON_SITELIBDIR%%/ceph_detect_init/__init__.pyc Error: Orphaned: sbin/ceph-disk-udev Error: Orphaned: @dir etc/init.d Comment Actions Is this a requirement? What options are you running poudriere with, because my runs 'just work' Comment Actions The difference between my Poudriere and yours is probably the following line in /etc/make.conf: Comment Actions Alan, I'll set the Developer=yes in /etc/make.conf. You did not answer the first question: is it required? In corosync it is only 2 files that need to be removed. So that is easy. Comment Actions Nope. If you set it in the base file system, Poudriere will automatically copy it to the jail.
As far as I'm concerned, it is. Plus, it will make things much easier the next time you update the port. If Ceph adds a new file, you'll notice.
Poudriere makes it obvious when DEVELOPER=yes. I'll email you my full Poudriere log so you can see. Comment Actions poudriere testport sets DEVELOPER=yes automatically. (as does bulk -t) make makeplist does the find and %% dance for you, why bother doing it manually ?
Comment Actions **>>>! In D9584#199162, @wjw_digiware.nl wrote:
I do not want all the ceph_tests_* and ceph_bench* tools in the package. Comment Actions Mat, Alan, I think that this version runs poudriere testport without complaints/errors. Comment Actions Almost done. But there are a few more portlint warnings. As @mat said, you don't need to worry about portlint's "NLS knob" warning, but you should fix the others. Comment Actions It looks like you accidentally excluded UIDs, GIDs, and net/Makefile from the most recent revision. Remember, when you're using Phabricator to update a revision, you must always put every modified file on the command line, even if you haven't touched that file since the last update. Otherwise, Phabricator thinks that you want to remove those files from the review. Apart from that, lgtm. You still need approval from @mat, because i'm not a ports committer. Comment Actions Other than that, it looks good, I assume that you have tested that poudriere testport does not complain about anything ? (the "I think" you said makes me wonder)
Comment Actions That says a bit about me.... I'm rarely confident that everything is satisfied. The duplicate lips are due to either portlint or poudriere complaining about missing these references. Comment Actions Used your suggestion for the DOC files So that is it, ready to go?
Comment Actions Well, this, here, is a code review tool, we review code, and make it better, and then commit it. For non committers, I still think that once everything is ok, a PR should be openned with the final patch so that it is added to the tree. I don't have the spare time to test-build it and commit it. Comment Actions @mat, Thanx, I'll update the PR with this patch and a link to this as review process, Comment Actions Added my mentors for review-before-commit process. (@mat is already here, I added @feld too) Comment Actions I can't seem to apply this cleanly $ arc patch D9584 A net/ceph-devel A net/ceph-devel/files Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: net/ceph-devel/pkg-plist |=================================================================== |--- /dev/null |+++ net/ceph-devel/pkg-plist -------------------------- (Creating file net/ceph-devel/pkg-plist...) Patching file net/ceph-devel/pkg-plist using Plan A... Empty context always matches. Hunk #1 succeeded at 1. done Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: net/ceph-devel/pkg-descr |=================================================================== |--- /dev/null |+++ net/ceph-devel/pkg-descr -------------------------- (Creating file net/ceph-devel/pkg-descr...) Patching file net/ceph-devel/pkg-descr using Plan A... Empty context always matches. Hunk #1 succeeded at 1. done Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: net/ceph-devel/files/patch-src_rocksdb_CMakeLists.txt |=================================================================== |--- /dev/null |+++ net/ceph-devel/files/patch-src_rocksdb_CMakeLists.txt -------------------------- (Creating file net/ceph-devel/files/patch-src_rocksdb_CMakeLists.txt...) Patching file net/ceph-devel/files/patch-src_rocksdb_CMakeLists.txt using Plan A... Empty context always matches. Hunk #1 succeeded at 1. done Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: net/ceph-devel/files/ceph.in |=================================================================== |--- /dev/null |+++ net/ceph-devel/files/ceph.in -------------------------- (Creating file net/ceph-devel/files/ceph.in...) Patching file net/ceph-devel/files/ceph.in using Plan A... Empty context always matches. Hunk #1 succeeded at 1. done Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: net/ceph-devel/distinfo |=================================================================== |--- /dev/null |+++ net/ceph-devel/distinfo -------------------------- (Creating file net/ceph-devel/distinfo...) Patching file net/ceph-devel/distinfo using Plan A... Empty context always matches. Hunk #1 succeeded at 1. done Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: net/ceph-devel/Makefile |=================================================================== |--- /dev/null |+++ net/ceph-devel/Makefile -------------------------- (Creating file net/ceph-devel/Makefile...) Patching file net/ceph-devel/Makefile using Plan A... Empty context always matches. Hunk #1 succeeded at 1. done Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: net/Makefile |=================================================================== |--- net/Makefile |+++ net/Makefile -------------------------- Patching file net/Makefile using Plan A... Reversed (or previously applied) patch detected! Assume -R? [y] Hunk #1 succeeded at 67. done Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: UIDs |=================================================================== |--- UIDs |+++ UIDs -------------------------- Patching file UIDs using Plan A... Hunk #1 failed at 113. 1 out of 1 hunks failed--saving rejects to UIDs.rej done Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: GIDs |=================================================================== |--- GIDs |+++ GIDs -------------------------- Patching file GIDs using Plan A... Hunk #1 failed at 108. 1 out of 1 hunks failed--saving rejects to GIDs.rej done svn: warning: W150002: '/usr/ports/net/ceph-devel/files' is already under version control svn: E200009: Could not add all targets because some targets are already versioned svn: E200009: Illegal target for the requested operation A net/ceph-devel/pkg-plist A net/ceph-devel/pkg-descr A net/ceph-devel/files/patch-src_rocksdb_CMakeLists.txt A net/ceph-devel/files/ceph.in A net/ceph-devel/distinfo A net/ceph-devel/Makefile svn: warning: W150002: '/usr/ports/net/ceph-devel' is already under version control svn: E200009: Could not add all targets because some targets are already versioned svn: E200009: Illegal target for the requested operation property 'fbsd:nokeywords' set on 'net/ceph-devel/pkg-plist' svn: E135001: Unrecognized line ending style 'native \ No newline at end of property' for '/usr/ports/net/ceph-devel/pkg-plist' svn: E125004: MIME type 'text/plain \ No newline at end of property' contains invalid character ' ' in media type property 'fbsd:nokeywords' set on 'net/ceph-devel/pkg-descr' svn: E135001: Unrecognized line ending style 'native \ No newline at end of property' for '/usr/ports/net/ceph-devel/pkg-descr' svn: E125004: MIME type 'text/plain \ No newline at end of property' contains invalid character ' ' in media type property 'fbsd:nokeywords' set on 'net/ceph-devel/files/patch-src_rocksdb_CMakeLists.txt' svn: E135001: Unrecognized line ending style 'native \ No newline at end of property' for '/usr/ports/net/ceph-devel/files/patch-src_rocksdb_CMakeLists.txt' svn: E125004: MIME type 'text/plain \ No newline at end of property' contains invalid character ' ' in media type svn: E135001: Unrecognized line ending style 'native \ No newline at end of property' for '/usr/ports/net/ceph-devel/files/ceph.in' property 'svn:executable' set on 'net/ceph-devel/files/ceph.in' svn: E125004: MIME type 'text/plain \ No newline at end of property' contains invalid character ' ' in media type property 'fbsd:nokeywords' set on 'net/ceph-devel/distinfo' svn: E135001: Unrecognized line ending style 'native \ No newline at end of property' for '/usr/ports/net/ceph-devel/distinfo' svn: E125004: MIME type 'text/plain \ No newline at end of property' contains invalid character ' ' in media type svn: E135001: Unrecognized line ending style 'native \ No newline at end of property' for '/usr/ports/net/ceph-devel/Makefile' property 'svn:keywords' set on 'net/ceph-devel/Makefile' svn: E125004: MIME type 'text/plain \ No newline at end of property' contains invalid character ' ' in media type Comment Actions @feld What version are you using to patch on? Then there is a lot of svn complaints, about which I know very little. `arc patch D9584` to see what comes of it. Comment Actions Hmm, yeah. Comment Actions Oke, I see... Sorry about this. Comment Actions Yeah. :-) It'd be great if you can sync phabricato patch with latest patch on Bugzilla, for tonight. (generally syncing patches in these two reduces confusings :-]) Also, you did great job on this ceph ports, personally I appreciate __/|\__ Comment Actions net/ceph-devel: integrating mmokhi patches.
Comment Actions net/ceph-devel: integrating mmokhi patches.
Comment Actions @feld Any other things I need to do to get this committed?
Comment Actions Thanx Mark,
gopher 70/tcp I used to run Gopher servers in the old days.... :) |