games/quake2-data-gog: new port
Needs ReviewPublic
Actions

Authored by kami on Feb 13 2017, 9:07 PM.

Details

Reviewers

Summary

games/quake2-data-gog: new port

Test Plan

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 7456
Build 7618: arc lint + arc unit

kami retitled this revision from to games/quake2-data-gog: new port.

kami updated this object.

kami edited the test plan for this revision. (Show Details)

kami added reviewers: cs, koobs.

games/quake2-data-gog/Makefile
24	Is this one really needed as you extract in WRKSRC anyway ?
75	Don't use do-* and pre-* or post-, put everything into do-.
100	This should be in do-install-DOCS-on:

Apply requested changes:

Do what the previous change tried to do.

games/quake2-data-gog/Makefile
89–93	You could create `do-install-MGAME_${_install:tu}-on:` targets there, and then you would not need to include b.port.options.m.

lifanov added inline comments.

games/quake2-data-gog/Makefile
21	This looks weird with fetch being disabled. Can you switch this to EXTRACT_DEPENDS?

kami edited reviewers, added: miwi, adamw; removed: cs, koobs.May 16 2017, 8:12 AM

games/quake2-data-gog/pkg-descr
5	I think you should add instructions here on what file to download, and where to place it. `pkg-descr` is the first place people will look for that info.
games/quake2-data-gog/pkg-plist
408	Documentation typically is switched by `%%PORTDOCS%%`, not `%%DOCS%%`.