games/quake2-data-gog: new port

[kami]

Summary

games/quake2-data-gog: new port

Test Plan

poudriere

Jail \ Port	games/quake2-data-gog
10.3-RELEASE-p16 amd64	OK
10.3-RELEASE-p16 i386	OK
11.0-RELEASE-p7 amd64	OK
11.0-RELEASE-p7 i386	OK

[mat]

games/quake2-data-gog/Makefile

24

Is this one really needed as you extract in WRKSRC anyway ?

75

Don't use do-* and pre-* or post-*, put everything into do-*.

100

This should be in do-install-DOCS-on:

[kami]

Apply requested changes:

• Merge do-extract and post-extract
• Use do-install-DOCS-on

[kami]

Do what the previous change tried to do.

[mat]

games/quake2-data-gog/Makefile

88–92

You could create do-install-MGAME_${_install:tu}-on: targets there, and then you would not need to include b.port.options.m.

[lifanov]

games/quake2-data-gog/Makefile

20

This looks weird with fetch being disabled. Can you switch this to EXTRACT_DEPENDS?

[kami]

• Use do-instale-GAME_*-on
• Use EXTRACT_DEPENDS instead of FETCH_DEPENDS
• Sort plist

[adamw]

games/quake2-data-gog/pkg-descr

5

I think you should add instructions here on what file to download, and where to place it. pkg-descr is the first place people will look for that info.

games/quake2-data-gog/pkg-plist

408

Documentation typically is switched by %%PORTDOCS%%, not %%DOCS%%.