Page MenuHomeFreeBSD
Differential D9578

games/yquake2: new port
Needs ReviewPublic
Actions

Authored by kami on Feb 13 2017, 9:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 10, 4:58 PM
Unknown Object (File)
Sat, Nov 8, 11:13 PM
Unknown Object (File)
Sun, Oct 26, 7:56 PM
Unknown Object (File)
Thu, Oct 23, 4:38 AM
Unknown Object (File)
Tue, Oct 21, 12:49 PM
Unknown Object (File)
Tue, Oct 21, 1:06 AM
Unknown Object (File)
Tue, Oct 21, 1:06 AM
Unknown Object (File)
Tue, Oct 21, 1:05 AM
View All Files
Subscribers
mat

Details

Reviewers
adamw
Summary
games/yquake2: new port
Test Plan

poudriere

Jail \ Portgames/yquake2
10.3-RELEASE-p16 amd64OK
10.3-RELEASE-p16 i386OK
11.0-RELEASE-p7 amd64OK
11.0-RELEASE-p7 i386OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 7540
Build 7694: arc lint + arc unit

Event Timeline

kami updated this revision to Diff 25117.Feb 13 2017, 9:20 PM
kami retitled this revision from to games/yquake2: new port.
kami updated this object.
kami edited the test plan for this revision. (Show Details)
kami added reviewers: cs, koobs.
Herald added a subscriber: mat. · View Herald TranscriptFeb 13 2017, 9:20 PM
kami added a parent revision: D9576: games/quake2-data-gog: new port.Feb 13 2017, 9:21 PM
kami added a child revision: D9580: games/yquake2-ctf: new port.Feb 13 2017, 9:36 PM
kami added a child revision: D9581: games/yquake2-rogue: new port.
kami added a child revision: D9582: games/yquake2-xatrix: new port.
mat added inline comments.Feb 14 2017, 8:23 AM
games/yquake2/Makefile
29

This should probably be:

DISTVERSIONPREFIX= QUAKE2_
DISTVERSION= 6_00

31

As this is the default, it is not needed.

67

why include bsd.port.pre.mk here ?

kami updated this revision to Diff 25176.Feb 14 2017, 7:10 PM

Use DISTVERSIONPREFIX and DISTVERSION instead of setting DISTFILES
directly.

kami mentioned this in D9580: games/yquake2-ctf: new port.Feb 14 2017, 7:16 PM
kami mentioned this in D9581: games/yquake2-rogue: new port.Feb 14 2017, 7:21 PM
kami mentioned this in D9582: games/yquake2-xatrix: new port.
mat added inline comments.Feb 14 2017, 9:10 PM
games/yquake2/Makefile
67

This is still an open point, I do not think there is a need to include it.

kami updated this revision to Diff 25325.Feb 17 2017, 7:39 PM

Redesign do-install to avoid bsd.port.pre.mk.

kami edited reviewers, added: miwi, adamw; removed: cs, koobs.May 16 2017, 8:12 AM
miwi removed a reviewer: miwi.Sep 20 2017, 4:16 PM

Revision Contents
Changeset List

PathSize
games/
1 line
73 lines
16 lines
3 lines
5 lines
12 lines
9 lines

Diff 25325

View Options

games/Makefile

Loading...
View Options

games/yquake2/

Loading...
View Options

games/yquake2/Makefile

Loading...
View Options

games/yquake2/Makefile.include

Loading...
View Options

games/yquake2/distinfo

Loading...
View Options

games/yquake2/files/

Loading...
View Options

games/yquake2/files/wrapper.in

Loading...
View Options

games/yquake2/pkg-descr

Loading...
View Options

games/yquake2/pkg-plist

Loading...