Page MenuHomeFreeBSD
Differential D9308

Garbage collect IFT_IEEE80211
ClosedPublic
Actions

Authored by avos on Jan 23 2017, 10:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 5, 7:48 AM
Unknown Object (File)
Tue, Jun 30, 10:01 PM
Unknown Object (File)
Tue, Jun 30, 10:51 AM
Unknown Object (File)
Fri, Jun 26, 11:06 PM
Unknown Object (File)
Fri, Jun 26, 8:06 PM
Unknown Object (File)
Wed, Jun 17, 9:55 PM
Unknown Object (File)
Sat, Jun 13, 12:26 PM
Unknown Object (File)
Mon, Jun 8, 9:24 AM
View All Files
Subscribers
imp

Details

Reviewers
glebius
adrian
Group Reviewers
network
Commits
rS312929: Garbage collect IFT_IEEE80211 (but leave the define for possible reuse)
Summary

This interface type ("a parent interface of wlanX") is not used since rS287197 .

Test Plan

There are no other references to it in the source tree; however, an exp-run may be needed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

avos updated this revision to Diff 24358.Jan 23 2017, 10:30 PM
avos retitled this revision from to Garbage collect IFT_IEEE80211.
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added reviewers: adrian, glebius, network.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJan 23 2017, 10:30 PM
adrian accepted this revision.Jan 23 2017, 11:02 PM
adrian edited edge metadata.

i'm okay with this. I wonder if we want to reuse it for say, WDS sub interfaces, or upcoming P2P/TDLS subinterfaces where they'll definitely want to appear as child interfaces to a wlanX interface.

This revision is now accepted and ready to land.Jan 23 2017, 11:02 PM
glebius accepted this revision.Jan 27 2017, 1:13 AM
glebius edited edge metadata.
glebius added inline comments.
sys/net/if_types.h
116

Better leave the define.

glebius added a comment.Jan 27 2017, 1:18 AM

Btw, the etc/network.subr now can be cleaned up from legacy code in childif_create().

Closed by commit rS312929: Garbage collect IFT_IEEE80211 (but leave the define for possible reuse) (authored by avos). · Explain WhyJan 28 2017, 5:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
net/
1 line
1 line
netinet6/
1 line
1 line
2 lines
2 lines
usr.sbin/
rtsold/
2 lines

Diff 24358

View Options

sys/net/if.c

Loading...
View Options

sys/net/if_types.h

Loading...
View Options

sys/netinet6/in6.c

Loading...
View Options

sys/netinet6/in6_ifattach.c

Loading...
View Options

sys/netinet6/nd6.c

Loading...
View Options

sys/netinet6/nd6_nbr.c

Loading...
View Options

usr.sbin/rtsold/if.c

Loading...