Page MenuHomeFreeBSD
Differential D9029

Extract do-patch into a separate script.
ClosedPublic
Actions

Authored by mat on Jan 3 2017, 2:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 4:41 AM
Unknown Object (File)
Tue, Mar 11, 8:18 PM
Unknown Object (File)
Tue, Mar 4, 8:35 AM
Unknown Object (File)
Tue, Mar 4, 2:45 AM
Unknown Object (File)
Tue, Mar 4, 1:55 AM
Unknown Object (File)
Tue, Mar 4, 1:22 AM
Unknown Object (File)
Mon, Mar 3, 11:15 PM
Unknown Object (File)
Fri, Feb 21, 4:31 PM
View All Files
Subscribers
bapt
emaste
julian

Details

Reviewers
None
Group Reviewers
portmgr
Commits
rP431680: Extract do-patch into a separate script.
Summary

Implement EXTRA_PATCH_TREE. (idea from the PR)

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6546
Build 6770: arc lint + arc unit

Event Timeline

mat updated this revision to Diff 23572.Jan 3 2017, 2:17 PM
mat retitled this revision from to Extract do-patch into a separate script. Implement EXTRA_PATCH_TREE. (idea from the PR).
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added a reviewer: portmgr.
mat added subscribers: bapt, julian.
julian added a comment.Jan 4 2017, 8:14 PM

this is obviously part of a bigger change, so I can't comment on that part but the part about the EXTRA_PATCH_TREE looks like it should work.
I don't see why one would have a compressed patch file but handling it shouldn't hurt. (except by hiding bugs through added complexity.)

mat updated this revision to Diff 23878.Jan 11 2017, 2:26 PM
mat retitled this revision from Extract do-patch into a separate script. Implement EXTRA_PATCH_TREE. (idea from the PR) to Extract do-patch into a separate script..
mat updated this object.
  • Fixup EXTRA_PATCHES missing the :-pX argument.
  • Implement EXTRA_PATCH_TREE. (idea from the PR)
  • Remove PATCH_WRKSRC from PATCH_ARGS.
  • Don't go through apply_one_patch for local files.
mat updated this revision to Diff 23879.Jan 11 2017, 3:06 PM
  • Use the framework correctly.
  • "Fix" ports using PATCH_ARGS to patch things manually (???)
Herald added a subscriber: emaste. · View Herald TranscriptJan 11 2017, 3:06 PM
Closed by commit rP431680: Extract do-patch into a separate script. (authored by mat). · Explain WhyJan 16 2017, 4:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Mk/
Scripts/
115 lines
102 lines

Diff 23572

View Options

Mk/Scripts/do-patch.sh

Loading...
View Options

Mk/bsd.port.mk

Loading...