Page MenuHomeFreeBSD
Differential D8949

sfxge(4): add missing barrier in common code MCDI response handling
ClosedPublic
Actions

Authored by arybchik on Dec 28 2016, 3:55 PM.
Tags
None
Referenced Files
F131731239: D8949.id23373.diff
Fri, Oct 10, 5:31 PM
F131723793: D8949.diff
Fri, Oct 10, 4:01 PM
F131722112: D8949.id23337.diff
Fri, Oct 10, 3:41 PM
Unknown Object (File)
Tue, Sep 23, 10:41 AM
Unknown Object (File)
Thu, Sep 18, 11:28 AM
Unknown Object (File)
Sep 7 2025, 11:02 PM
Unknown Object (File)
Jul 14 2025, 12:53 AM
Unknown Object (File)
Jul 4 2025, 9:10 PM
View All 75 Files
Subscribers
imp

Details

Reviewers
philip
np
gnn
bz
Commits
rS310750: sfxge(4): add missing barrier in common code MCDI response handling
Summary

The semantics of the MCDI interfacve require reading the first
dword of the header before any other data in the buffer. Add
a barrier to the common code MCDI handler to enforce this.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 kernels tinderbox build tested

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6428
Build 6660: arc lint + arc unit

Event Timeline

arybchik updated this revision to Diff 23337.Dec 28 2016, 3:55 PM
arybchik retitled this revision from to sfxge(4): add missing barrier in common code MCDI response handling.
arybchik updated this object.
arybchik edited the test plan for this revision. (Show Details)
arybchik added reviewers: gnn, philip, np, bz.
Herald added a subscriber: imp. · View Herald TranscriptDec 28 2016, 3:55 PM
gnn accepted this revision.Dec 28 2016, 4:43 PM
gnn edited edge metadata.
This revision is now accepted and ready to land.Dec 28 2016, 4:43 PM
Closed by commit rS310750: sfxge(4): add missing barrier in common code MCDI response handling (authored by arybchik). · Explain WhyDec 29 2016, 6:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
common/
2 lines

Diff 23337

View Options

head/sys/dev/sfxge/common/ef10_mcdi.c

Loading...