Page MenuHomeFreeBSD
Differential D8821

aw_clk honor CLK_SET_DRYRUN
ClosedPublic
Actions

Authored by manu on Dec 16 2016, 7:21 PM.
Tags
Referenced Files
F174474657: D8821.id23015.diff
Sat, Oct 3, 1:03 PM
F174471117: D8821.id23008.diff
Sat, Oct 3, 12:36 PM
F174351783: D8821.diff
Fri, Oct 2, 3:15 PM
Unknown Object (File)
Thu, Oct 1, 8:52 PM
Unknown Object (File)
Fri, Sep 11, 2:33 AM
Unknown Object (File)
Thu, Sep 10, 8:27 PM
Unknown Object (File)
Tue, Sep 8, 7:39 PM
Unknown Object (File)
Tue, Sep 8, 4:30 AM
View All Files
Subscribers
andrew
imp

Details

Reviewers
jmcneill
Group Reviewers
ARM
Commits
rS310178: Honor the CLK_SET_DRYRUN for the *set_freq function for allwinner clocks.
Summary

Honor the CLK_SET_DRYRUN for the *set_freq function for allwinner clocks.

Test Plan

Tested on A20 SOM EVB

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6281
Build 6521: arc lint + arc unit

Event Timeline

manu updated this revision to Diff 23008.Dec 16 2016, 7:21 PM
manu retitled this revision from to aw_clk honor CLK_SET_DRYRUN.
manu updated this object.
manu edited the test plan for this revision. (Show Details)
manu added reviewers: ARM, jmcneill.
manu set the repository for this revision to rS FreeBSD src repository - subversion.
manu added a project: ARM.
Herald added subscribers: andrew, imp. · View Herald TranscriptDec 16 2016, 7:21 PM
jmcneill added inline comments.Dec 16 2016, 8:19 PM
sys/arm/allwinner/clk/aw_debeclk.c
215

if ((flags & CLK_SET_DRYRUN) != 0)

sys/arm/allwinner/clk/aw_lcdclk.c
422

Why fetch parent_clk freq twice?

manu updated this revision to Diff 23015.Dec 16 2016, 8:30 PM
manu removed rS FreeBSD src repository - subversion as the repository for this revision.

Remove copy/paste error and explicitly compare flags with dryrun.

manu marked 2 inline comments as done.Dec 16 2016, 8:31 PM
jmcneill accepted this revision.Dec 16 2016, 9:36 PM
jmcneill edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 9:36 PM
Closed by commit rS310178: Honor the CLK_SET_DRYRUN for the *set_freq function for allwinner clocks. (authored by manu). · Explain WhyDec 16 2016, 9:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
arm/
allwinner/
clk/
9 lines
9 lines
83 lines
83 lines
30 lines
24 lines
3 lines

Diff 23015

View Options

sys/arm/allwinner/clk/aw_debeclk.c

Loading...
View Options

sys/arm/allwinner/clk/aw_hdmiclk.c

Loading...
View Options

sys/arm/allwinner/clk/aw_lcdclk.c

Loading...
View Options

sys/arm/allwinner/clk/aw_mmcclk.c

Loading...
View Options

sys/arm/allwinner/clk/aw_modclk.c

Loading...
View Options

sys/arm/allwinner/clk/aw_pll.c

Loading...
View Options

sys/arm/allwinner/clk/aw_thsclk.c

Loading...