Paths

Table of Contentst

Differential D8769

Switch Rockchip RK3188 SoC to use the platform code
ClosedPublic
Actions

Authored by ganbold on Dec 13 2016, 10:42 AM.

Tags

None

Referenced Files

	F168787320: D8769.id22864.diff
	Sun, Aug 30, 3:58 AM

	F168768554: D8769.id22866.diff
	Sun, Aug 30, 1:34 AM

	Unknown Object (File)
	Sat, Aug 29, 1:56 AM

	Unknown Object (File)
	Fri, Aug 28, 8:01 PM

	Unknown Object (File)
	Fri, Aug 28, 3:10 PM

	Unknown Object (File)
	Thu, Aug 27, 4:29 AM

	Unknown Object (File)
	Wed, Aug 26, 7:34 PM

	Unknown Object (File)
	Wed, Aug 26, 5:51 PM

Subscribers

Details

Reviewers

Commits

rS310019: Switch Rockchip RK3188 SoC to use the platform code.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 6209

Event Timeline

ganbold updated this revision to Diff 22862.Dec 13 2016, 10:42 AM

ganbold retitled this revision from to Switch Rockchip RK3188 SoC to use the platform code.

ganbold updated this object.

ganbold edited the test plan for this revision. (Show Details)

ganbold added a reviewer: andrew.

ganbold set the repository for this revision to rS FreeBSD src repository - subversion.

ganbold added a subscriber: ARM.

Herald added a subscriber: imp. · View Herald TranscriptDec 13 2016, 10:42 AM

Include changes to RK3188 config

manu added a subscriber: manu.Dec 13 2016, 10:51 AM

manu added inline comments.

sys/arm/rockchip/rk30xx_machdep.c
93	It should be in a #ifdef SOC_RK3188
98	#ifdef SMP

Added SOC_ROCKCHIP_RK3188 option.

Added SOC_ROCKCHIP_RK3188 option and SMP check.

Consider my comments as suggestions for future improvements.

/usr/src/sys/conf/options.arm
67 ↗	(On Diff #22865)	I'm wondering if we should start moving to `opt_soc.h` on arm.
sys/arm/conf/RK3188
26 ↗	(On Diff #22865)	There seems to be inconsistent indenting here.
sys/arm/rockchip/rk30xx_machdep.c
55–60	This should probably be the default implementation

This revision is now accepted and ready to land.Dec 13 2016, 11:16 AM

Closed by commit rS310019: Switch Rockchip RK3188 SoC to use the platform code. (authored by ganbold). · Explain WhyDec 13 2016, 11:44 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

arm/

rockchip/

rk30xx_machdep.c

45 lines

38 lines

8 lines

Diff 22862

sys/arm/rockchip/rk30xx_machdep.c

Loading...

sys/arm/rockchip/rk30xx_mp.h

Loading...

sys/arm/rockchip/rk30xx_mp.c

Loading...