libm: remove duplicate version script entries
ClosedPublic
Actions

Authored by emaste on Nov 24 2016, 1:23 AM.

Details

Reviewers

imp
br

Group Reviewers

ARM

Commits

rS309298: libm: remove duplicate version script entries

Summary

These symbols already appear in the common lib/msun/Symbol.map. Duplicate entries produce an error with LLVM's LLD linker.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 22474.Nov 24 2016, 1:23 AM

emaste retitled this revision from to libm: remove duplicate MIPS version script entries.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: br, imp.

should we remove from arm and riscv as well ?

update to remove duplicates from arm and riscv, in addition to mips (reported by @br)

br accepted this revision.Nov 28 2016, 11:57 PM

br edited edge metadata.

This revision is now accepted and ready to land.Nov 28 2016, 11:57 PM

Closed by commit rS309298: libm: remove duplicate version script entries (authored by emaste). · Explain WhyNov 29 2016, 6:40 PM

This revision was automatically updated to reflect the committed changes.

For reference these were added to the main Symbol.map in rS226218 and added again on arm in rS230367, and then copied to risc-v and mips.

Revision Contents
Changeset List

Path

Size

lib/

msun/

arm/

Symbol.map

5 lines

mips/

Symbol.map

5 lines

riscv/

Symbol.map

5 lines

Diff 22590

View Options

lib/msun/arm/Symbol.map

View Options

lib/msun/mips/Symbol.map

View Options

libm: remove duplicate version script entriesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22590

lib/msun/arm/Symbol.map

lib/msun/mips/Symbol.map

lib/msun/riscv/Symbol.map

libm: remove duplicate version script entries
ClosedPublic
Actions

Revision Contents
Changeset List