Page MenuHomeFreeBSD
Differential D8627

libm: remove duplicate version script entries
ClosedPublic
Actions

Authored by emaste on Nov 24 2016, 1:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 4:26 AM
Unknown Object (File)
Oct 20 2024, 10:04 AM
Unknown Object (File)
Oct 18 2024, 7:37 AM
Unknown Object (File)
Oct 15 2024, 2:24 AM
Unknown Object (File)
Oct 2 2024, 8:25 PM
Unknown Object (File)
Oct 1 2024, 9:42 PM
Unknown Object (File)
Oct 1 2024, 1:24 PM
Unknown Object (File)
Sep 27 2024, 5:48 AM
View All 72 Files
Subscribers
None

Details

Reviewers
imp
br
Group Reviewers
ARM
Commits
rS309298: libm: remove duplicate version script entries
Summary

These symbols already appear in the common lib/msun/Symbol.map. Duplicate entries produce an error with LLVM's LLD linker.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 22474.Nov 24 2016, 1:23 AM
emaste retitled this revision from to libm: remove duplicate MIPS version script entries.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: br, imp.
br edited edge metadata.Nov 24 2016, 8:54 AM

should we remove from arm and riscv as well ?

emaste updated this revision to Diff 22590.Nov 28 2016, 10:04 PM
emaste retitled this revision from libm: remove duplicate MIPS version script entries to libm: remove duplicate version script entries.
emaste added a reviewer: ARM.
  • update to remove duplicates from arm and riscv, in addition to mips (reported by @br)
br accepted this revision.Nov 28 2016, 11:57 PM
br edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2016, 11:57 PM
Closed by commit rS309298: libm: remove duplicate version script entries (authored by emaste). · Explain WhyNov 29 2016, 6:40 PM
This revision was automatically updated to reflect the committed changes.
emaste added a comment.Nov 29 2016, 6:52 PM

For reference these were added to the main Symbol.map in rS226218 and added again on arm in rS230367, and then copied to risc-v and mips.

Revision Contents
Changeset List

PathSize
head/
lib/
msun/
arm/
5 lines
mips/
5 lines
riscv/
5 lines

Diff 22599

View Options

head/lib/msun/arm/Symbol.map

Loading...
View Options

head/lib/msun/mips/Symbol.map

Loading...
View Options

head/lib/msun/riscv/Symbol.map

Loading...