Page MenuHomeFreeBSD

Disallow recursion on the free page queue mutex
ClosedPublic

Authored by alc on Nov 24 2016, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 1, 3:25 PM
Unknown Object (File)
Tue, Jul 1, 2:18 AM
Unknown Object (File)
Mon, Jun 30, 9:10 AM
Unknown Object (File)
Fri, Jun 27, 12:30 PM
Unknown Object (File)
Tue, Jun 24, 2:33 AM
Unknown Object (File)
Sun, Jun 22, 9:15 PM
Unknown Object (File)
Sat, Jun 21, 3:47 PM
Unknown Object (File)
Fri, Jun 20, 7:28 AM
Subscribers

Details

Summary

Recursion on the free page queue mutex occurred when UMA needed to allocate a new page of radix trie nodes to complete a vm_radix_insert() operation that was requested by vm_page_cache(). vm_page_cache() already held the free page queue lock when UMA tried to acquire it through its call to vm_page_alloc(). This code path no longer exists, so there is no reason to allow recursion on the free page queue mutex.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

alc retitled this revision from to Disallow recursion on the free page queue mutex.
alc updated this object.
alc edited the test plan for this revision. (Show Details)
alc added reviewers: kib, markj.
markj edited edge metadata.
This revision is now accepted and ready to land.Nov 24 2016, 8:01 PM
kib edited edge metadata.

Peter, could you please test this patch.

In D8628#179071, @alc wrote:

Peter, could you please test this patch.

Sure. I ran a buildworld + all the stress2 tests I have.
No problems seen.

This revision was automatically updated to reflect the committed changes.