Disallow recursion on the free page queue mutex
ClosedPublic
Actions

Authored by alc on Nov 24 2016, 6:56 PM.

Details

Reviewers

kib
markj

Commits

rS309203: Recursion on the free page queue mutex occurred when UMA needed to allocate

Summary

Recursion on the free page queue mutex occurred when UMA needed to allocate a new page of radix trie nodes to complete a vm_radix_insert() operation that was requested by vm_page_cache(). vm_page_cache() already held the free page queue lock when UMA tried to acquire it through its call to vm_page_alloc(). This code path no longer exists, so there is no reason to allow recursion on the free page queue mutex.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alc updated this revision to Diff 22483.Nov 24 2016, 6:56 PM

alc retitled this revision from to Disallow recursion on the free page queue mutex.

alc updated this object.

alc edited the test plan for this revision. (Show Details)

alc added reviewers: kib, markj.

markj accepted this revision.Nov 24 2016, 8:01 PM

markj edited edge metadata.

This revision is now accepted and ready to land.Nov 24 2016, 8:01 PM

kib accepted this revision.Nov 24 2016, 8:16 PM

kib edited edge metadata.

Peter, could you please test this patch.

In D8628#179071, @alc wrote:

Peter, could you please test this patch.

Sure. I ran a buildworld + all the stress2 tests I have.
No problems seen.

Closed by commit rS309203: Recursion on the free page queue mutex occurred when UMA needed to allocate (authored by alc). · Explain WhyNov 27 2016, 1:43 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_page.c

15 lines

Diff 22533

View Options

Disallow recursion on the free page queue mutexClosedPublicActions