Rewrite linux_recvfrom. To avoid double conversion of sockaddr use kern_recvit() directly. And check fromlen parameter before sockaddr copyin and conversion.
ClosedPublic
Actions

Authored by dchagin on Nov 2 2014, 10:17 PM.

Tags

None

Referenced Files

	F169974014: D1082.diff
	Thu, Sep 3, 3:48 AM

	Unknown Object (File)
	Wed, Sep 2, 6:57 PM

	Unknown Object (File)
	Wed, Sep 2, 5:37 AM

	Unknown Object (File)
	Tue, Sep 1, 12:44 AM

	Unknown Object (File)
	Mon, Aug 31, 7:06 PM

	Unknown Object (File)
	Mon, Aug 31, 5:31 AM

	Unknown Object (File)
	Sun, Aug 30, 12:35 AM

	Unknown Object (File)
	Sat, Aug 29, 6:56 PM

View All Files

Subscribers

imp

trasz

Details

Reviewers

None

Group Reviewers

Linux Emulation

Commits

rS283433: Rewrite linux_recvfrom. To avoid double conversion of sockaddr use

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

dchagin updated this revision to Diff 2228.Nov 2 2014, 10:17 PM

dchagin retitled this revision from to Rewrite linux_recvfrom. To avoid double conversion of sockaddr use kern_recvit() directly. And check fromlen parameter before sockaddr copyin and conversion..

dchagin added a reviewer: Linux Emulation.Nov 2 2014, 10:19 PM

trasz added a subscriber: trasz.Mar 27 2015, 11:19 AM

trasz added inline comments.

sys/compat/linux/linux_socket.c
1035	!= 0; few other occurences below.
1053	sys_recvfrom() calls recvit() here, which also copies out the msg_namelen. It seems to be missing here.
1057	!= NULL