Differential D1082

Rewrite linux_recvfrom. To avoid double conversion of sockaddr use kern_recvit() directly. And check fromlen parameter before sockaddr copyin and conversion.
ClosedPublic
Actions

Authored by dchagin on Nov 2 2014, 10:17 PM.

Details

Reviewers

None

Group Reviewers

Linux Emulation

Commits

rS283433: Rewrite linux_recvfrom. To avoid double conversion of sockaddr use

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin updated this revision to Diff 2228.Nov 2 2014, 10:17 PM

dchagin retitled this revision from to Rewrite linux_recvfrom. To avoid double conversion of sockaddr use kern_recvit() directly. And check fromlen parameter before sockaddr copyin and conversion..

dchagin added a reviewer: Linux Emulation.Nov 2 2014, 10:19 PM

trasz added a subscriber: trasz.Mar 27 2015, 11:19 AM

trasz added inline comments.

sys/compat/linux/linux_socket.c
1035 ↗	(On Diff #2228)	!= 0; few other occurences below.
1053 ↗	(On Diff #2228)	sys_recvfrom() calls recvit() here, which also copies out the msg_namelen. It seems to be missing here.
1057 ↗	(On Diff #2228)	!= NULL