Add AT_RANDOM and AT_EXECFN auxiliary vector entries which are used by glibc. At list since glibc version 2.16 using AT_RANDOM is mandatory.
ClosedPublic
Actions

Authored by dchagin on Nov 2 2014, 10:15 PM.

Details

Reviewers

None

Group Reviewers

Linux Emulation

Commits

rS283431: Add AT_RANDOM and AT_EXECFN auxiliary vector entries which are used by

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

dchagin updated this revision to Diff 2226.Nov 2 2014, 10:15 PM

dchagin retitled this revision from to Add AT_RANDOM and AT_EXECFN auxiliary vector entries which are used by glibc. At list since glibc version 2.16 using AT_RANDOM is mandatory..

dchagin added a reviewer: Linux Emulation.Nov 2 2014, 10:19 PM

Unfortunate that we have three very similar copies of linux_copyout_strings

sys/amd64/linux/linux_sysvec.c
351	Is it right to call this "canary"? From the kernel's perspective we're just providing some random bytes.

dchagin added inline comments.Dec 27 2014, 2:40 PM

sys/amd64/linux/linux_sysvec.c
351	It's a our exec_copyout_strings() counterpart

In D1080#3, @emaste wrote:

Unfortunate that we have three very similar copies of linux_copyout_strings

hmm, I'll look at it

trasz added a subscriber: trasz.Mar 31 2015, 3:24 PM

trasz added inline comments.

sys/amd64/linux/linux_sysvec.c
324	I don't understand that piece of code very well, but you increased LINUX_AT_COUNT by 2, and here you are using 1 _or_ 2 additional elements. Is that ok?