Details
Details
- Reviewers
- None
- Group Reviewers
Linux Emulation - Commits
- rS283431: Add AT_RANDOM and AT_EXECFN auxiliary vector entries which are used by
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Unfortunate that we have three very similar copies of linux_copyout_strings
sys/amd64/linux/linux_sysvec.c | ||
---|---|---|
351 ↗ | (On Diff #2226) | Is it right to call this "canary"? From the kernel's perspective we're just providing some random bytes. |
sys/amd64/linux/linux_sysvec.c | ||
---|---|---|
351 ↗ | (On Diff #2226) | It's a our exec_copyout_strings() counterpart |
sys/amd64/linux/linux_sysvec.c | ||
---|---|---|
324 ↗ | (On Diff #2226) | I don't understand that piece of code very well, but you increased LINUX_AT_COUNT by 2, and here you are using 1 _or_ 2 additional elements. Is that ok? |