Paths

Table of Contentst

Differential D1080

Add AT_RANDOM and AT_EXECFN auxiliary vector entries which are used by glibc. At list since glibc version 2.16 using AT_RANDOM is mandatory.
ClosedPublic
Actions

Authored by dchagin on Nov 2 2014, 10:15 PM.

Tags

None

Referenced Files

	F152410518: D1080.id5638.diff
	Tue, Apr 14, 7:20 PM

	F152409453: D1080.id5638.diff
	Tue, Apr 14, 7:12 PM

	Unknown Object (File)
	Mon, Apr 6, 11:44 AM

	Unknown Object (File)
	Sat, Apr 4, 3:17 PM

	Unknown Object (File)
	Sat, Apr 4, 2:00 AM

	Unknown Object (File)
	Fri, Apr 3, 11:24 AM

	Unknown Object (File)
	Wed, Apr 1, 7:47 AM

	Unknown Object (File)
	Wed, Apr 1, 7:37 AM

Subscribers

Details

Reviewers

None

Group Reviewers

Linux Emulation

Commits

rS283431: Add AT_RANDOM and AT_EXECFN auxiliary vector entries which are used by

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin updated this revision to Diff 2226.Nov 2 2014, 10:15 PM

dchagin retitled this revision from to Add AT_RANDOM and AT_EXECFN auxiliary vector entries which are used by glibc. At list since glibc version 2.16 using AT_RANDOM is mandatory..

dchagin added a reviewer: Linux Emulation.Nov 2 2014, 10:19 PM

Unfortunate that we have three very similar copies of linux_copyout_strings

sys/amd64/linux/linux_sysvec.c
351 ↗	(On Diff #2226)	Is it right to call this "canary"? From the kernel's perspective we're just providing some random bytes.

dchagin added inline comments.Dec 27 2014, 2:40 PM

sys/amd64/linux/linux_sysvec.c
351 ↗	(On Diff #2226)	It's a our exec_copyout_strings() counterpart

In D1080#3, @emaste wrote:

Unfortunate that we have three very similar copies of linux_copyout_strings

hmm, I'll look at it

trasz added a subscriber: trasz.Mar 31 2015, 3:24 PM

trasz added inline comments.

sys/amd64/linux/linux_sysvec.c
324 ↗	(On Diff #2226)	I don't understand that piece of code very well, but you increased LINUX_AT_COUNT by 2, and here you are using 1 _or_ 2 additional elements. Is that ok?

Closed by commit rS283431: Add AT_RANDOM and AT_EXECFN auxiliary vector entries which are used by (authored by dchagin). · Explain WhyMay 24 2015, 4:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

linux/

2 lines

26 lines

linux32/

2 lines

linux32_sysvec.c

26 lines

compat/

linux/

3 lines

i386/

linux/

2 lines

26 lines

Diff 5638

head/sys/amd64/linux/linux.h

Loading...

head/sys/amd64/linux/linux_sysvec.c

Loading...

head/sys/amd64/linux32/linux.h

Loading...

head/sys/amd64/linux32/linux32_sysvec.c

Loading...

head/sys/compat/linux/linux_misc.h

Loading...

head/sys/i386/linux/linux.h

Loading...

head/sys/i386/linux/linux_sysvec.c

Loading...