Page MenuHomeFreeBSD
Differential D8529

Full softfloat and hardfloat support for RISC-V
ClosedPublic
Actions

Authored by br on Nov 15 2016, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 4:06 PM
Unknown Object (File)
Sat, Mar 1, 2:20 PM
Unknown Object (File)
Sat, Mar 1, 12:55 PM
Unknown Object (File)
Sat, Mar 1, 5:43 AM
Unknown Object (File)
Tue, Feb 25, 9:24 AM
Unknown Object (File)
Jan 24 2025, 10:09 PM
Unknown Object (File)
Jan 24 2025, 10:21 AM
Unknown Object (File)
Jan 20 2025, 2:55 PM
View All Files
Subscribers
andrew
bdrewery

Details

Reviewers
emaste
Commits
rS308731: Add full softfloat and hardfloat support for RISC-V.
Summary

Tested by hand in SMP environment. Works stable. No testsuite available for RISC-V yet due to missing C plus plus

N.B. There is no floating point exception traps on RISC-V.
N.B. No flq, fsq (for quad access) instructions supported yet by GCC 6.1

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br updated this revision to Diff 22224.Nov 15 2016, 4:57 PM
br retitled this revision from to Full softfloat and hardfloat support for RISC-V.
br updated this object.
br edited the test plan for this revision. (Show Details)
br added a reviewer: emaste.
Herald added a subscriber: bdrewery. · View Herald TranscriptNov 15 2016, 4:57 PM
br updated this object.Nov 15 2016, 4:59 PM
br updated this object.Nov 15 2016, 5:05 PM
emaste added inline comments.Nov 16 2016, 2:35 AM
lib/libc/riscv/gen/_setjmp.S
63–80

Should you commit this (and related) independently?

br updated this revision to Diff 22255.Nov 16 2016, 12:05 PM

fix comment; use ifndef SOFTFLOAT for setjmp

andrew added a subscriber: andrew.Nov 16 2016, 2:51 PM
andrew added inline comments.
lib/msun/riscv/fenv.h
77–78

You could move this to the #else below.

share/mk/src.opts.mk
239

I think this could be ... || ${__TT} == "riscv"

Closed by commit rS308731: Add full softfloat and hardfloat support for RISC-V. (authored by br). · Explain WhyNov 16 2016, 3:21 PM
This revision was automatically updated to reflect the committed changes.
br added inline comments.Nov 16 2016, 3:23 PM
share/mk/src.opts.mk
239

thanks Andrew, will know!

Revision Contents
Changeset List

PathSize
2 lines
1 line
gnu/
usr.bin/
cc/
2 lines
lib/
libc/
3 lines
riscv/
4 lines
18 lines
gen/
64 lines
25 lines
60 lines
softfloat/
48 lines
86 lines
315 lines
softfloat/
3 lines
libcompiler_rt/
7 lines
msun/
riscv/
5 lines
21 lines
134 lines
11 lines
share/
mk/
4 lines
2 lines
6 lines
2 lines
sys/
conf/
2 lines
modules/
dtrace/
dtrace/
4 lines
riscv/
conf/
2 lines
include/
38 lines
25 lines
5 lines
8 lines
riscv/
2 lines
82 lines
7 lines
167 lines
13 lines
4 lines

Diff 22255

View Options

Makefile

Show First 20 Lines • Show All 2,545 Lines • ▼ Show 20 Lines for (;;) {
} }
ceiling = RTP_PRIO_MAX - ceiling; ceiling = RTP_PRIO_MAX - ceiling;
if (ceiling > RTP_PRIO_MAX) { if (ceiling > RTP_PRIO_MAX) {
error = EINVAL; error = EINVAL;
goto out; goto out;
} }
mtx_lock(&umtx_lock); mtx_lock(&umtx_lock);
if (UPRI(td) < PRI_MIN_REALTIME + ceiling) { if (td->td_base_user_pri < PRI_MIN_REALTIME + ceiling) {
mtx_unlock(&umtx_lock); mtx_unlock(&umtx_lock);
error = EINVAL; error = EINVAL;
goto out; goto out;
} }
if (su && PRI_MIN_REALTIME + ceiling < uq->uq_inherited_pri) { if (su && PRI_MIN_REALTIME + ceiling < uq->uq_inherited_pri) {
uq->uq_inherited_pri = PRI_MIN_REALTIME + ceiling; uq->uq_inherited_pri = PRI_MIN_REALTIME + ceiling;
thread_lock(td); thread_lock(td);
if (uq->uq_inherited_pri < UPRI(td)) if (uq->uq_inherited_pri < UPRI(td))
▲ Show 20 Lines • Show All 2,636 Lines • Show Last 20 Lines
View Options

Makefile.inc1

Show First 20 Lines • Show All 2,545 Lines • ▼ Show 20 Lines for (;;) {
} }
ceiling = RTP_PRIO_MAX - ceiling; ceiling = RTP_PRIO_MAX - ceiling;
if (ceiling > RTP_PRIO_MAX) { if (ceiling > RTP_PRIO_MAX) {
error = EINVAL; error = EINVAL;
goto out; goto out;
} }
mtx_lock(&umtx_lock); mtx_lock(&umtx_lock);
if (UPRI(td) < PRI_MIN_REALTIME + ceiling) { if (td->td_base_user_pri < PRI_MIN_REALTIME + ceiling) {
mtx_unlock(&umtx_lock); mtx_unlock(&umtx_lock);
error = EINVAL; error = EINVAL;
goto out; goto out;
} }
if (su && PRI_MIN_REALTIME + ceiling < uq->uq_inherited_pri) { if (su && PRI_MIN_REALTIME + ceiling < uq->uq_inherited_pri) {
uq->uq_inherited_pri = PRI_MIN_REALTIME + ceiling; uq->uq_inherited_pri = PRI_MIN_REALTIME + ceiling;
thread_lock(td); thread_lock(td);
if (uq->uq_inherited_pri < UPRI(td)) if (uq->uq_inherited_pri < UPRI(td))
▲ Show 20 Lines • Show All 2,636 Lines • Show Last 20 Lines
View Options

gnu/usr.bin/cc/Makefile.tgt

Show First 20 Lines • Show All 2,545 Lines • ▼ Show 20 Lines for (;;) {
} }
ceiling = RTP_PRIO_MAX - ceiling; ceiling = RTP_PRIO_MAX - ceiling;
if (ceiling > RTP_PRIO_MAX) { if (ceiling > RTP_PRIO_MAX) {
error = EINVAL; error = EINVAL;
goto out; goto out;
} }
mtx_lock(&umtx_lock); mtx_lock(&umtx_lock);
if (UPRI(td) < PRI_MIN_REALTIME + ceiling) { if (td->td_base_user_pri < PRI_MIN_REALTIME + ceiling) {
mtx_unlock(&umtx_lock); mtx_unlock(&umtx_lock);
error = EINVAL; error = EINVAL;
goto out; goto out;
} }
if (su && PRI_MIN_REALTIME + ceiling < uq->uq_inherited_pri) { if (su && PRI_MIN_REALTIME + ceiling < uq->uq_inherited_pri) {
uq->uq_inherited_pri = PRI_MIN_REALTIME + ceiling; uq->uq_inherited_pri = PRI_MIN_REALTIME + ceiling;
thread_lock(td); thread_lock(td);
if (uq->uq_inherited_pri < UPRI(td)) if (uq->uq_inherited_pri < UPRI(td))
▲ Show 20 Lines • Show All 2,636 Lines • Show Last 20 Lines
View Options

lib/libc/Makefile

Show First 20 Lines • Show All 2,545 Lines • ▼ Show 20 Lines for (;;) {
} }
ceiling = RTP_PRIO_MAX - ceiling; ceiling = RTP_PRIO_MAX - ceiling;
if (ceiling > RTP_PRIO_MAX) { if (ceiling > RTP_PRIO_MAX) {
error = EINVAL; error = EINVAL;
goto out; goto out;
} }
mtx_lock(&umtx_lock); mtx_lock(&umtx_lock);
if (UPRI(td) < PRI_MIN_REALTIME + ceiling) { if (td->td_base_user_pri < PRI_MIN_REALTIME + ceiling) {
mtx_unlock(&umtx_lock); mtx_unlock(&umtx_lock);
error = EINVAL; error = EINVAL;
goto out; goto out;
} }
if (su && PRI_MIN_REALTIME + ceiling < uq->uq_inherited_pri) { if (su && PRI_MIN_REALTIME + ceiling < uq->uq_inherited_pri) {
uq->uq_inherited_pri = PRI_MIN_REALTIME + ceiling; uq->uq_inherited_pri = PRI_MIN_REALTIME + ceiling;
thread_lock(td); thread_lock(td);
if (uq->uq_inherited_pri < UPRI(td)) if (uq->uq_inherited_pri < UPRI(td))
▲ Show 20 Lines • Show All 2,636 Lines • Show Last 20 Lines
View Options

lib/libc/riscv/Makefile.inc

Loading...
View Options

lib/libc/riscv/Symbol.map

Loading...
View Options

lib/libc/riscv/gen/_setjmp.S

Loading...
View Options

lib/libc/riscv/gen/flt_rounds.c

Loading...
View Options

lib/libc/riscv/gen/setjmp.S

Loading...
View Options

lib/libc/riscv/softfloat/milieu.h

Loading...
View Options

lib/libc/riscv/softfloat/riscv-gcc.h

Loading...
View Options

lib/libc/riscv/softfloat/softfloat.h

Loading...
View Options

lib/libc/softfloat/Makefile.inc

Loading...
View Options

lib/libcompiler_rt/Makefile.inc

Loading...
View Options

lib/msun/riscv/Makefile.inc

Loading...
View Options

lib/msun/riscv/Symbol.map

Loading...
View Options

lib/msun/riscv/fenv.h

Loading...
View Options

lib/msun/riscv/fenv.c

Loading...
View Options

share/mk/bsd.cpu.mk

Loading...
View Options

share/mk/local.meta.sys.mk

Loading...
View Options

share/mk/src.opts.mk

Loading...
View Options

share/mk/sys.mk

Loading...
View Options

sys/conf/options.riscv

Loading...
View Options

sys/modules/dtrace/dtrace/Makefile

Loading...
View Options

sys/riscv/conf/GENERIC

Loading...
View Options

sys/riscv/include/fpe.h

Loading...
View Options

sys/riscv/include/pcb.h

Loading...
View Options

sys/riscv/include/reg.h

Loading...
View Options

sys/riscv/include/riscvreg.h

Loading...
View Options

sys/riscv/riscv/genassym.c

Loading...
View Options

sys/riscv/riscv/machdep.c

Loading...
View Options

sys/riscv/riscv/mp_machdep.c

Loading...
View Options

sys/riscv/riscv/swtch.S

Loading...
View Options

sys/riscv/riscv/trap.c

Loading...
View Options

sys/riscv/riscv/vm_machdep.c

Loading...