strings: fix exit status if a file before the last one fails
ClosedPublic
Actions

Authored by emaste on Oct 25 2016, 5:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 19, 8:51 PM

	Unknown Object (File)
	Fri, Apr 19, 5:18 AM

	Unknown Object (File)
	Wed, Apr 17, 6:13 AM

	Unknown Object (File)
	Tue, Apr 9, 6:04 AM

	Unknown Object (File)
	Sat, Apr 6, 2:08 AM

	Unknown Object (File)
	Tue, Apr 2, 7:43 PM

	Unknown Object (File)
	Tue, Apr 2, 5:57 PM

	Unknown Object (File)
	Mar 2 2024, 8:10 PM

View All 61 Files

Subscribers

brooks

dim

Details

Reviewers

brooks
kaiw
jkoshy_users.sourceforge.net

Commits

rS307969: strings: fix exit status if a file before the last one fails

Summary

Previously a command like "strings f1 f2 f3" reported the exit status based only on processing the last file.

As with GNU strings, report an error exit status if an error was encountered processing any of the files. While here simplify the exit status handling to just success (0) / failure (1).

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 21672.Oct 25 2016, 5:50 PM

emaste retitled this revision from to strings: fix exit status if a file before the last one fails.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: jkoshy_users.sourceforge.net, kaiw.

emaste added subscribers: brooks, dim.

LGTM

This revision is now accepted and ready to land.Oct 25 2016, 5:56 PM

Closed by commit rS307969: strings: fix exit status if a file before the last one fails (authored by emaste). · Explain WhyOct 26 2016, 5:08 PM

This revision was automatically updated to reflect the committed changes.

patch looks good to me

Revision Contents
Changeset List

Path

Size

strings/

strings.c

27 lines

Diff 21672

View Options

strings: fix exit status if a file before the last one failsClosedPublicActions