Page MenuHomeFreeBSD
Differential D8254

Retry_count in minidump 64 bit code delaying ENOSPC by around 30 minutes for live cores.
ClosedPublic
Actions

Authored by raviprakash.darbha_gmail.com on Oct 14 2016, 10:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 5 2024, 1:15 AM
Unknown Object (File)
Feb 1 2024, 1:20 PM
Unknown Object (File)
Jan 28 2024, 5:44 PM
Unknown Object (File)
Jan 19 2024, 4:38 PM
Unknown Object (File)
Jan 13 2024, 6:21 PM
Unknown Object (File)
Dec 22 2023, 9:54 PM
Unknown Object (File)
Dec 10 2023, 4:40 AM
Unknown Object (File)
Nov 15 2023, 3:46 AM
View All 48 Files
Subscribers
cem
imp
markj
Contributor Reviews (src)

Details

Reviewers
markj
cem
Commits
rS307540: Add sysctl to make amd64 minidump retry count tunable at runtime.
Summary

I notice that when, the system runs out of space and we are trying to get a live core dump there is delay of around 30 minutes to return ENOSPC to the upper layers. This is on AMD64. As I go through the code , I see a retry count in amd64 not present in other platforms in sys/amd64/amd64/minidump_machdep.c . Its compared against 5 ( Not sure where that number comes from ). Because of this, the live core generation in our platform is delayed and as the memory map keeps increasing( lots of other stuff running ) it makes things worse. I want to make this retry count a tunable so that it can be changed at runtime accordingly.

Test Plan

I have verified this behavior on our platform and works as intended.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

raviprakash.darbha_gmail.com updated this revision to Diff 21404.Oct 14 2016, 10:15 PM
raviprakash.darbha_gmail.com retitled this revision from to Retry_count in minidump 64 bit code delaying ENOSPC by around 30 minutes for live cores..
raviprakash.darbha_gmail.com updated this object.
raviprakash.darbha_gmail.com edited the test plan for this revision. (Show Details)
raviprakash.darbha_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptOct 14 2016, 10:15 PM
cem added a subscriber: cem.Oct 14 2016, 11:14 PM

Please upload a diff with full context. (Either use diff -U9999 or arc.)

sys/amd64/amd64/minidump_machdep.c
77–78

This can just be SYSCTL_INT(..., CTLFLAG_RWTUN, ...).

raviprakash.darbha_gmail.com updated this revision to Diff 21424.Oct 15 2016, 11:40 PM

added the full file for more context. Also merged TUNABLE and SYSCTL_INT into one command.

cem accepted this revision.Oct 16 2016, 12:57 AM
cem added a reviewer: cem.
This revision is now accepted and ready to land.Oct 16 2016, 12:57 AM
markj accepted this revision.Oct 16 2016, 1:43 AM
markj added a reviewer: markj.
markj added a subscriber: markj.

LGTM with those nits fixed.

sys/amd64/amd64/minidump_machdep.c
35

This should be sorted between msgbuf.h and watchdog.h.

72

dump_retry_count seems like a better name to me.

raviprakash.darbha_gmail.com updated this revision to Diff 21425.Oct 16 2016, 2:05 AM
raviprakash.darbha_gmail.com edited edge metadata.

Addressed comments by markj

This revision now requires review to proceed.Oct 16 2016, 2:05 AM
cem accepted this revision.Oct 16 2016, 2:16 AM
cem edited edge metadata.
This revision is now accepted and ready to land.Oct 16 2016, 2:16 AM
Closed by commit rS307540: Add sysctl to make amd64 minidump retry count tunable at runtime. (authored by stevek). · Explain WhyOct 17 2016, 10:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
6 lines

Diff 21425

View Options

sys/amd64/amd64/minidump_machdep.c

Loading...