Page MenuHomeFreeBSD
Differential D8169

Change the way opt_USE is worked on, so that it is not evaluated too early.
ClosedPublic
Actions

Authored by mat on Oct 7 2016, 7:03 AM.
Tags
None
Referenced Files
F106174682: D8169.id21131.diff
Thu, Dec 26, 3:12 PM
Unknown Object (File)
Mon, Dec 9, 1:05 AM
Unknown Object (File)
Nov 13 2024, 2:06 PM
Unknown Object (File)
Oct 27 2024, 4:14 PM
Unknown Object (File)
Oct 27 2024, 4:11 PM
Unknown Object (File)
Oct 22 2024, 5:43 PM
Unknown Object (File)
Sep 26 2024, 2:50 PM
Unknown Object (File)
Sep 25 2024, 6:58 PM
View All 73 Files
Subscribers
jrm

Details

Reviewers
brnrd
Group Reviewers
portmgr
Commits
rP423859: Change the way opt_USE is parsed.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mat updated this revision to Diff 21131.Oct 7 2016, 7:03 AM
mat retitled this revision from to Change the way opt_USE is worked on, so that it is not evaluated too early..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added a reviewer: portmgr.Oct 7 2016, 8:15 AM
jrm added a subscriber: jrm.Oct 7 2016, 3:30 PM
jrm added inline comments.Oct 7 2016, 3:33 PM
Mk/bsd.options.mk
500 ↗(On Diff #21131)

Would a check here and on line 550 be useful to determine if USE_${_u:tu} already contains _u?

For example,

OPT1_USE= ldconfig=${PREFIX}/lib/blah/lib
OPT2_USE= ldconfig=${PREFIX}/lib/blah/lib

results in USE_LDCONFIG containing the same path twice.

brnrd added a reviewer: brnrd.Oct 7 2016, 7:12 PM
brnrd accepted this revision.Oct 7 2016, 7:21 PM
brnrd edited edge metadata.

Tested this and it results in the same behavior as an empty USE_LDCONFIG= .

This revision is now accepted and ready to land.Oct 7 2016, 7:21 PM
mat added inline comments.Oct 12 2016, 10:31 AM
Mk/bsd.options.mk
500 ↗(On Diff #21131)

Well, in this case, you are asking for it to be put twice.

What you want to do is:

.if ${PORT_OPTIONS:MOPT1} || ${PORT_OPTIONS:MOPT2}
USE_LDCONFIG+= ${PREFIX}/lib/blah/lib
.endif

Closed by commit rP423859: Change the way opt_USE is parsed. (authored by mat). · Explain WhyOct 12 2016, 12:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
12 linesO5: Ports Framework

Diff 21307

View Options

head/Mk/bsd.options.mk

Loading...