Page MenuHomeFreeBSD

Change the way opt_USE is worked on, so that it is not evaluated too early.
ClosedPublic

Authored by mat on Oct 7 2016, 7:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 2:06 PM
Unknown Object (File)
Oct 27 2024, 4:14 PM
Unknown Object (File)
Oct 27 2024, 4:11 PM
Unknown Object (File)
Oct 22 2024, 5:43 PM
Unknown Object (File)
Sep 26 2024, 2:50 PM
Unknown Object (File)
Sep 25 2024, 6:58 PM
Unknown Object (File)
Sep 25 2024, 2:49 PM
Unknown Object (File)
Sep 24 2024, 11:26 PM
Subscribers

Details

Reviewers
brnrd
Group Reviewers
portmgr
Commits
rP423859: Change the way opt_USE is parsed.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mat retitled this revision from to Change the way opt_USE is worked on, so that it is not evaluated too early..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
Mk/bsd.options.mk
500 โ†—(On Diff #21131)

Would a check here and on line 550 be useful to determine if USE_${_u:tu} already contains _u?

For example,

OPT1_USE= ldconfig=${PREFIX}/lib/blah/lib
OPT2_USE= ldconfig=${PREFIX}/lib/blah/lib

results in USE_LDCONFIG containing the same path twice.

brnrd edited edge metadata.

Tested this and it results in the same behavior as an empty USE_LDCONFIG= .

This revision is now accepted and ready to land.Oct 7 2016, 7:21 PM
Mk/bsd.options.mk
500 โ†—(On Diff #21131)

Well, in this case, you are asking for it to be put twice.

What you want to do is:

.if ${PORT_OPTIONS:MOPT1} || ${PORT_OPTIONS:MOPT2}
USE_LDCONFIG+= ${PREFIX}/lib/blah/lib
.endif

This revision was automatically updated to reflect the committed changes.