Remove an extraneous call to soisconnected() in syncache_socket(), introduced with r261242.
ClosedPublic
Actions

Authored by jch on Sep 29 2016, 11:43 AM.

Details

Reviewers

hiren
gnn
adrian

Group Reviewers

transport

Commits

rS308426: MFC r307966:
rS308263: MFC r307966:
rS307966: Remove an extraneous call to soisconnected() in syncache_socket(),

Summary

Remove an extraneous call to soisconnected() in syncache_socket(), introduced with rS261242
The useful and expected soisconnected() call is done in tcp_do_segment().

Has been found as part of PR:212920 investigation.

Improve slightly (~2%) the maximum number of TCP accept per second.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5350
Build 5538: arc lint + arc unit

Event Timeline

jch updated this revision to Diff 20806.Sep 29 2016, 11:43 AM

jch retitled this revision from to Remove an extraneous call to soisconnected() in syncache_socket(), introduced with r261242..

jch updated this object.

jch edited the test plan for this revision. (Show Details)

jch added reviewers: gnn, hiren, adrian.

Herald added a reviewer: transport. · View Herald TranscriptSep 29 2016, 11:43 AM

jch updated this object.Sep 30 2016, 6:52 AM

jch edited edge metadata.

As far as I can tell this is good. I have a box serving large volume of internet facing traffic with a data accept filter.

LGTM

This revision is now accepted and ready to land.Oct 3 2016, 9:59 AM

As Kevin mentioned, this looks good on prod traffic at llnw.

Thanks for your time on this review, will push this change as soon as D8211: Fix a double-free when an inp transitions to INP_TIMEWAIT state after having been dropped. is complete.

Closed by commit rS307966: Remove an extraneous call to soisconnected() in syncache_socket(), (authored by jch). · Explain WhyOct 26 2016, 3:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_syncache.c

4 lines

Diff 20806

View Options

sys/netinet/tcp_syncache.c

Context not available.
	LIST_FOREACH(s, &ih->states, entry) {	LIST_FOREACH(s, &ih->states, entry) {
	s->timeout = PFTM_PURGE;	s->timeout = PFTM_PURGE;
	/* Don't send out individual delete messages. */	/* Don't send out individual delete messages. */
	s->sync_state = PFSTATE_NOSYNC;	s->state_flags \|= PFSTATE_NOSYNC;
	pf_unlink_state(s, PF_ENTER_LOCKED);	pf_unlink_state(s, PF_ENTER_LOCKED);
	goto relock;	goto relock;
	}	}
Context not available.

Remove an extraneous call to soisconnected() in syncache_socket(), introduced with r261242.ClosedPublicActions