Page MenuHomeFreeBSD
Differential D8072

Remove an extraneous call to soisconnected() in syncache_socket(), introduced with r261242.
ClosedPublic
Actions

Authored by jch on Sep 29 2016, 11:43 AM.
Tags
None
Referenced Files
F131736709: D8072.id21703.diff
Fri, Oct 10, 6:37 PM
Unknown Object (File)
Sat, Sep 20, 9:47 AM
Unknown Object (File)
Fri, Sep 19, 3:22 PM
Unknown Object (File)
Fri, Sep 19, 12:24 PM
Unknown Object (File)
Mon, Sep 15, 7:36 PM
Unknown Object (File)
Mon, Sep 15, 2:18 AM
Unknown Object (File)
Sat, Sep 13, 1:38 PM
Unknown Object (File)
Sep 5 2025, 11:01 PM
View All Files
Subscribers
kbowling

Details

Reviewers
hiren
gnn
adrian
Group Reviewers
transport
Commits
rS308426: MFC r307966:
rS308263: MFC r307966:
rS307966: Remove an extraneous call to soisconnected() in syncache_socket(),
Summary

Remove an extraneous call to soisconnected() in syncache_socket(), introduced with rS261242
The useful and expected soisconnected() call is done in tcp_do_segment().

Has been found as part of PR:212920 investigation.

Improve slightly (~2%) the maximum number of TCP accept per second.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5350
Build 5538: arc lint + arc unit

Event Timeline

jch updated this revision to Diff 20806.Sep 29 2016, 11:43 AM
jch retitled this revision from to Remove an extraneous call to soisconnected() in syncache_socket(), introduced with r261242..
jch updated this object.
jch edited the test plan for this revision. (Show Details)
jch added reviewers: gnn, hiren, adrian.
Herald added a reviewer: transport. · View Herald TranscriptSep 29 2016, 11:43 AM
jch updated this object.Sep 30 2016, 6:52 AM
jch edited edge metadata.
kbowling added a subscriber: kbowling.Oct 3 2016, 7:22 AM

As far as I can tell this is good. I have a box serving large volume of internet facing traffic with a data accept filter.

gnn accepted this revision.Oct 3 2016, 9:59 AM
gnn edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 3 2016, 9:59 AM
hiren accepted this revision.Oct 12 2016, 1:03 AM
hiren edited edge metadata.

As Kevin mentioned, this looks good on prod traffic at llnw.

jch added a comment.Oct 12 2016, 6:52 AM

Thanks for your time on this review, will push this change as soon as D8211: Fix a double-free when an inp transitions to INP_TIMEWAIT state after having been dropped. is complete.

Closed by commit rS307966: Remove an extraneous call to soisconnected() in syncache_socket(), (authored by jch). · Explain WhyOct 26 2016, 3:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
netinet/
4 lines

Diff 20806

View Options

sys/netinet/tcp_syncache.c

Loading...