RPi-B Add MULTIDELAY
ClosedPublic
Actions

Authored by manu on Sep 28 2016, 4:45 PM.

Details

Reviewers

andrew
imp

Group Reviewers

ARM

Commits

rS331894: MFC r306436-r306437, r306489, r306491
rS306436: RPI-B: Add support for MULTIDELAY

Summary

Add MULTIDELAY for RPI-B

Test Plan

Tested on RPI-B

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu updated this revision to Diff 20775.Sep 28 2016, 4:45 PM

manu retitled this revision from to RPi-B Add MULTIDELAY.

manu updated this object.

manu edited the test plan for this revision. (Show Details)

manu added a reviewer: ARM.

manu set the repository for this revision to rS FreeBSD src repository - subversion.

manu added a project: ARM.

Herald added subscribers: andrew, imp. · View Herald TranscriptSep 28 2016, 4:45 PM

Modulo one small Q, this looks good to me.

sys/arm/broadcom/bcm2835/bcm2835_machdep.c
132 ↗	(On Diff #20775)	Do we know this platform has 200 cycles per us?

This revision is now accepted and ready to land.Sep 28 2016, 6:46 PM

In D8062#166787, @imp wrote:

Modulo one small Q, this looks good to me.

No idea, that was the number used before so I simply re-used it.

In D8062#166794, @manu wrote:

In D8062#166787, @imp wrote:

Modulo one small Q, this looks good to me.

No idea, that was the number used before so I simply re-used it.

Perhaps we should see, since it is used here:

static void
platform_delay(int usec, void *arg __unused)
{

int counts;

for (; usec > 0; usec--)
        for (counts = plat_obj->cls->delay_count; counts > 0; counts--)
                /*
                 * Prevent the compiler from optimizing
                 * out the loop
                 */
                cpufunc_nullop();

}

In D8062#166796, @imp wrote:
In D8062#166794, @manu wrote:

In D8062#166787, @imp wrote:

Modulo one small Q, this looks good to me.

No idea, that was the number used before so I simply re-used it.

Perhaps we should see, since it is used here:

static void
platform_delay(int usec, void *arg __unused)
{
int counts;

for (; usec > 0; usec--)
        for (counts = plat_obj->cls->delay_count; counts > 0; counts--)
                /*
                 * Prevent the compiler from optimizing
                 * out the loop
                 */
                cpufunc_nullop();
}