Add MULTIDELAY for RPI-B
Details
Details
- Reviewers
andrew imp - Group Reviewers
ARM - Commits
- rS331894: MFC r306436-r306437, r306489, r306491
rS306436: RPI-B: Add support for MULTIDELAY
Tested on RPI-B
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5338 Build 5525: arc lint + arc unit
Event Timeline
Comment Actions
Modulo one small Q, this looks good to me.
| sys/arm/broadcom/bcm2835/bcm2835_machdep.c | ||
|---|---|---|
| 132 | Do we know this platform has 200 cycles per us? | |
Comment Actions
Perhaps we should see, since it is used here:
static void
platform_delay(int usec, void *arg __unused)
{
int counts;
for (; usec > 0; usec--)
for (counts = plat_obj->cls->delay_count; counts > 0; counts--)
/*
* Prevent the compiler from optimizing
* out the loop
*/
cpufunc_nullop();}
Comment Actions
100 seems accurate enough.
But the platform bits for delay seems broken, the delay_count stays at 0.
| sys/arm/broadcom/bcm2835/bcm2835_machdep.c | ||
|---|---|---|
| 132 | We currently lack a way to measure this. It would need someone to think about how to do this across the different timers. | |