nmap as MASTERDIR
ClosedPublic
Actions

Authored by woodsb02 on Sep 13 2016, 3:59 PM.

Details

Reviewers

adamw
ohauer
koobs
mat

Commits

rP422291: security/zenmap: Update to 7.25 BETA2 and use security/nmap as MASTERDIR

Summary

security/zenmap: Update to 7.25 BETA2 and use security/nmap as MASTERDIR

security/nmap:

Ensure MAINTAINER and COMMENT do not clobber those of slave port
Add .if !defined(MASTERDIR) to prevent inclusion in slave port
Do not include bsd.port.options.mk, as none of the features are used

security/zenmap:

Convert to slave of security/nmap to ensure they are updated in lockstep
Inherently update to 7.25 BETA2 (current version of security/nmap)
Remove redundant port header variables included from MASTERDIR
PKGNAME of zenmap achieved using PKGNAMEPREFIX=ze and PORTNAME=nmap
Add LICENSE details, as they are separately documented in the distfile
Set directory variables so they are not inhereted from MASTERDIR
Convert post-extract to post-patch, as it is modifying WRKSRC files
Fix REINPLACE command, as it was leaving the line with nothing but a single ',' and causing the build to fail
Do not download external zenmap icon, as one is included in distfile

Test Plan

poudriere testport: ok on 9i386 and 12amd64
portint: looks ok

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 5141
Build 5248: arc lint + arc unit

Event Timeline

woodsb02 updated this revision to Diff 20308.Sep 13 2016, 3:59 PM

woodsb02 retitled this revision from to security/zenmap: Update to 7.25 BETA2 and use security/nmap as MASTERDIR.

woodsb02 updated this object.

woodsb02 edited the test plan for this revision. (Show Details)

woodsb02 added reviewers: adamw, mat, koobs, ohauer.

mat accepted this revision.Sep 13 2016, 5:31 PM

mat edited edge metadata.

mat added inline comments.

security/zenmap/Makefile
65	754 for a script is a bit pointless, but it was here before. Also, it should be set in the plist not here.

This revision is now accepted and ready to land.Sep 13 2016, 5:31 PM

Using the nmap port as master is OK for me, as long I don't have to fix zenmap issues after nmap updates ;)

Regarding the su-to-zenmap.sh script the following should also work and is a bit cleaner.
Use INSTALL_SCRIPT instead of initial "cp -a" and remove the chmod line so it looks like this:

before:
post-patch:

@${RM} ${WRKSRC}/install_scripts/unix/su-to-zenmap.sh
@${CP} -a ${FILESDIR}/pc-su ${WRKSRC}/install_scripts/unix/su-to-zenmap.sh

post-install:

@${CHMOD} 754 ${STAGEDIR}${DATADIR}/su-to-zenmap.sh

after:
post-patch:
+ @${RM} ${WRKSRC}/install_scripts/unix/su-to-zenmap.sh
+ @${INSTALL_SCRIPT} ${FILESDIR}/pc-su ${WRKSRC}/install_scripts/unix/su-to-zenmap.sh

Please forget the install script idea, after looking into the script I see it is not safe to have this scrip installed executable for others.

In D7880#163347, @ohauer wrote:

Using the nmap port as master is OK for me, as long I don't have to fix zenmap issues after nmap updates ;)

Interesting point, because I think I this would mean you shouldn't just update nmap without first testing zenmap still builds correctly. nemysis is still listed as the maintainer of zenmap, so would need to fix it if it does break, but it would/should delay your release of the nmap update.

However, I think this is how it should be. The two programs are distributed in the one distfile, and there is no guarantee that an older zenmap will work with a newer nmap, or vice versa.

woodsb02 added inline comments.Sep 13 2016, 10:42 PM

security/zenmap/Makefile
65	I thought this also, but the file is not listed in pkg-plist; it uses the python autoplist feature. This is the first port I have seen which supplements the python autoplist with additional files in a pkg-plist. So, without it in pkg-plist, I wonder what is the best way to install it with a different file mode?

In D7880#163348, @ohauer wrote:

Please forget the install script idea, after looking into the script I see it is not safe to have this scrip installed executable for others.

I actually thought it sounded like a pretty good idea. Why isn't it safe to be installed executable for others? The script simply calls a graphical program which will either use "su" or "sudo", and if "others" have the appropriate credentials to authenticate, why shouldn't they be allowed to?

nemysis has just reset their maintainership of security/zenmap.

ohauer: would you be interested in maintaining it, so that updating it inline with nmap only needs the one person?

Alternatively, I could maintain it, however it would mean zenmap will still need to be build tested before any commit to update nmap.

ohauer: would you be interested in maintaining it, so that updating it inline with nmap only needs the one person?

Hm, I don't use a gui on any of my systems and trying to keep out X components as much as possible, so I'm really not a good candidate to maintain zenmap.

Closed by commit rP422291: security/zenmap: Update to 7.25 BETA2 and use security/nmap as MASTERDIR (authored by woodsb02). · Explain WhySep 17 2016, 12:13 AM

This revision was automatically updated to reflect the committed changes.