Page MenuHomeFreeBSD
Differential D7566

Remove messy machdep code for Alpine V1 and use proper drivers instead
ClosedPublic
Actions

Authored by mst_semihalf.com on Aug 18 2016, 4:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 4, 10:31 AM
Unknown Object (File)
Feb 25 2025, 7:55 PM
Unknown Object (File)
Feb 23 2025, 8:56 PM
Unknown Object (File)
Feb 20 2025, 4:40 PM
Unknown Object (File)
Feb 18 2025, 10:11 AM
Unknown Object (File)
Feb 8 2025, 10:33 PM
Unknown Object (File)
Feb 8 2025, 4:56 PM
Unknown Object (File)
Feb 8 2025, 2:01 PM
View All Files
Subscribers
andrew
ARM

Details

Reviewers
wma
imp
• ian
Commits
rS305523: Remove messy machdep code for Alpine V1 and use proper drivers instead
Summary

Let drivers for Alpine CCU, NB and Serdes take care of internal SoC configuration.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mst_semihalf.com updated this revision to Diff 19461.Aug 18 2016, 4:42 PM
mst_semihalf.com retitled this revision from to Remove messy machdep code for Alpine V1 and use proper drivers instead.
mst_semihalf.com updated this object.
mst_semihalf.com edited the test plan for this revision. (Show Details)
mst_semihalf.com added reviewers: wma, • ian, imp.
mst_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
mst_semihalf.com added a subscriber: ARM.
Herald added a subscriber: andrew. · View Herald TranscriptAug 18 2016, 4:42 PM
mst_semihalf.com added a parent revision: D7565: Introduce support for Annapurna Alpine CCU and NB devices.Aug 18 2016, 4:43 PM
imp accepted this revision.Aug 19 2016, 3:41 AM
imp edited edge metadata.

Consider this more of a 'I like it' rather than a good, thorough technical review.

This revision is now accepted and ready to land.Aug 19 2016, 3:41 AM
mst_semihalf.com updated this revision to Diff 19543.Aug 22 2016, 4:48 PM
mst_semihalf.com edited edge metadata.

Use device entries instead of SOC option.

This revision now requires review to proceed.Aug 22 2016, 4:48 PM
mst_semihalf.com updated this revision to Diff 19871.Aug 31 2016, 1:33 PM
mst_semihalf.com edited edge metadata.

Add comments describing added devices in kernel conf.

Closed by commit rS305523: Remove messy machdep code for Alpine V1 and use proper drivers instead (authored by wma). · Explain WhySep 7 2016, 5:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
annapurna/
alpine/
39 lines
65 lines
conf/
4 lines

Diff 20124

View Options

head/sys/arm/annapurna/alpine/alpine_machdep.c

Show First 20 Lines • Show All 1,974 Lines • ▼ Show 20 Lines if (!fvdat) {
panic("FUSE: no vnode data during recycling"); panic("FUSE: no vnode data during recycling");
} }
LIST_FOREACH_SAFE(fufh, &fvdat->handles, next, fufh_tmp) { LIST_FOREACH_SAFE(fufh, &fvdat->handles, next, fufh_tmp) {
printf("FUSE: vnode being reclaimed with open fufh " printf("FUSE: vnode being reclaimed with open fufh "
"(type=%#x)", fufh->fufh_type); "(type=%#x)", fufh->fufh_type);
fuse_filehandle_close(vp, fufh, td, NULL); fuse_filehandle_close(vp, fufh, td, NULL);
} }
if (!fuse_isdeadfs(vp) && fvdat->nlookup > 0) { if (VTOI(vp) == 1) {
/*
* Don't send FUSE_FORGET for the root inode, because
* we never send FUSE_LOOKUP for it (see
* fuse_vfsop_root) and we don't want the server to see
* mismatched lookup counts.
*/
struct fuse_data *data;
struct vnode *vroot;
data = fuse_get_mpdata(vnode_mount(vp));
FUSE_LOCK();
vroot = data->vroot;
data->vroot = NULL;
FUSE_UNLOCK();
if (vroot)
vrele(vroot);
} else if (!fuse_isdeadfs(vp) && fvdat->nlookup > 0) {
fuse_internal_forget_send(vnode_mount(vp), td, NULL, VTOI(vp), fuse_internal_forget_send(vnode_mount(vp), td, NULL, VTOI(vp),
fvdat->nlookup); fvdat->nlookup);
} }
cache_purge(vp); cache_purge(vp);
vfs_hash_remove(vp); vfs_hash_remove(vp);
fuse_vnode_destroy(vp); fuse_vnode_destroy(vp);
return 0; return 0;
▲ Show 20 Lines • Show All 1,149 Lines • Show Last 20 Lines
View Options

head/sys/arm/annapurna/alpine/alpine_machdep_mp.c

Show First 20 Lines • Show All 1,974 Lines • ▼ Show 20 Lines if (!fvdat) {
panic("FUSE: no vnode data during recycling"); panic("FUSE: no vnode data during recycling");
} }
LIST_FOREACH_SAFE(fufh, &fvdat->handles, next, fufh_tmp) { LIST_FOREACH_SAFE(fufh, &fvdat->handles, next, fufh_tmp) {
printf("FUSE: vnode being reclaimed with open fufh " printf("FUSE: vnode being reclaimed with open fufh "
"(type=%#x)", fufh->fufh_type); "(type=%#x)", fufh->fufh_type);
fuse_filehandle_close(vp, fufh, td, NULL); fuse_filehandle_close(vp, fufh, td, NULL);
} }
if (!fuse_isdeadfs(vp) && fvdat->nlookup > 0) { if (VTOI(vp) == 1) {
/*
* Don't send FUSE_FORGET for the root inode, because
* we never send FUSE_LOOKUP for it (see
* fuse_vfsop_root) and we don't want the server to see
* mismatched lookup counts.
*/
struct fuse_data *data;
struct vnode *vroot;
data = fuse_get_mpdata(vnode_mount(vp));
FUSE_LOCK();
vroot = data->vroot;
data->vroot = NULL;
FUSE_UNLOCK();
if (vroot)
vrele(vroot);
} else if (!fuse_isdeadfs(vp) && fvdat->nlookup > 0) {
fuse_internal_forget_send(vnode_mount(vp), td, NULL, VTOI(vp), fuse_internal_forget_send(vnode_mount(vp), td, NULL, VTOI(vp),
fvdat->nlookup); fvdat->nlookup);
} }
cache_purge(vp); cache_purge(vp);
vfs_hash_remove(vp); vfs_hash_remove(vp);
fuse_vnode_destroy(vp); fuse_vnode_destroy(vp);
return 0; return 0;
▲ Show 20 Lines • Show All 1,149 Lines • Show Last 20 Lines
View Options

head/sys/arm/conf/ALPINE

Show First 20 Lines • Show All 1,974 Lines • ▼ Show 20 Lines if (!fvdat) {
panic("FUSE: no vnode data during recycling"); panic("FUSE: no vnode data during recycling");
} }
LIST_FOREACH_SAFE(fufh, &fvdat->handles, next, fufh_tmp) { LIST_FOREACH_SAFE(fufh, &fvdat->handles, next, fufh_tmp) {
printf("FUSE: vnode being reclaimed with open fufh " printf("FUSE: vnode being reclaimed with open fufh "
"(type=%#x)", fufh->fufh_type); "(type=%#x)", fufh->fufh_type);
fuse_filehandle_close(vp, fufh, td, NULL); fuse_filehandle_close(vp, fufh, td, NULL);
} }
if (!fuse_isdeadfs(vp) && fvdat->nlookup > 0) { if (VTOI(vp) == 1) {
/*
* Don't send FUSE_FORGET for the root inode, because
* we never send FUSE_LOOKUP for it (see
* fuse_vfsop_root) and we don't want the server to see
* mismatched lookup counts.
*/
struct fuse_data *data;
struct vnode *vroot;
data = fuse_get_mpdata(vnode_mount(vp));
FUSE_LOCK();
vroot = data->vroot;
data->vroot = NULL;
FUSE_UNLOCK();
if (vroot)
vrele(vroot);
} else if (!fuse_isdeadfs(vp) && fvdat->nlookup > 0) {
fuse_internal_forget_send(vnode_mount(vp), td, NULL, VTOI(vp), fuse_internal_forget_send(vnode_mount(vp), td, NULL, VTOI(vp),
fvdat->nlookup); fvdat->nlookup);
} }
cache_purge(vp); cache_purge(vp);
vfs_hash_remove(vp); vfs_hash_remove(vp);
fuse_vnode_destroy(vp); fuse_vnode_destroy(vp);
return 0; return 0;
▲ Show 20 Lines • Show All 1,149 Lines • Show Last 20 Lines