Submitted by: rwatson
Sponsored by: DARAP, AFRL
Details
Details
- Reviewers
kib jhb rwatson - Commits
- rS305288: Merge from CheriBSD:
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5012 Build 5081: arc lint + arc unit
Event Timeline
Comment Actions
Maybe see if kib@ cares. SIGPROP is a bit verbose, but a SP_ prefix probably implies "stack pointer" which is more confusing than SA_.
Comment Actions
I am curious why. Is the 'impression of collision' against the sigaction.sa_flags bits ?
sys/kern/kern_sig.c | ||
---|---|---|
199 | Formatting there is completely broken. You left second tab after symbol names in all lines except TTYSTOP and IGNORE, and the look of the block is awful now. Also, most lines become too long. | |
3062–3063 | This line becames too long and must be wrapped. |
Comment Actions
The impression of collision is indeed with sigaction.sa_flags. In CheriBSD we expose signal properties to MD code so they appear near each other.
sys/kern/kern_sig.c | ||
---|---|---|
203 | You may also use the opportunity to fix style in the table by adding spaces around '|'. |