Update cryptotest for modern algorithms.
ClosedPublic
Actions

Authored by gnn on Aug 22 2016, 5:27 PM.

Details

Reviewers

ae
ngie

Commits

rS305066: Update cryptotest for modern algorithms

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4881
Build 4944: arc lint + arc unit

Event Timeline

gnn updated this revision to Diff 19548.Aug 22 2016, 5:27 PM

gnn retitled this revision from to Update cryptotest for modern algorithms..

gnn updated this object.

gnn edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptAug 22 2016, 5:27 PM

gnn added reviewers: ngie, ae.Aug 22 2016, 5:30 PM

Why remove all the static from functions?

tools/tools/crypto/cryptotest.c
129–130	Seems gratuitous unless there is a real difference.
191	This check can be removed; the point is to cache the crypto file descriptor, which doesn't happen if it isn't static.
206	This seems a little lame. What if some softfoocrypt(4) shows up? Contrived, I guess.

There is no reason for the functions to be static at all, so removing them just cleans up the code and makes it trivially debuggable.

tools/tools/crypto/cryptotest.c
129–130	The difference is the key length and effects the benchmark.
206	When such a thing shows up I'll fix the benchmark code.

gnn marked 2 inline comments as done.Aug 23 2016, 12:53 PM

Address more comments.

Closed by commit rS305066: Update cryptotest for modern algorithms (authored by gnn). · Explain WhyAug 30 2016, 2:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

tools/

crypto/

cryptotest.c

45 lines

Diff 19548

View Options

tools/tools/crypto/cryptotest.c

Update cryptotest for modern algorithms.ClosedPublicActions