Graphing tools used by general IBS summary and C2C views. This adds the
ability to plot histograms, bargraphs and bitfields in the console.
Sponsored by: Netflix
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 79000 Build 75883: arc lint + arc unit
Event Timeline
Comment Actions
generally good (and cool functionality). Lots of nits.
| usr.sbin/pmc/display.cc | ||
|---|---|---|
| 517 | This breaks 32-bit builds. armv7 still builds this file. | |
| 815 | what happens with really long function names? Names larger than disp_width? | |
| 1102 | what if there's no rows? Then any value of row is out of bounds. Add a check for nrows here. | |
| 1257 | I think there's an off by one error here because bin == bwidth for the xmax sample. But the bins is only valid 0 to bwidth - 1. | |
| 1269 | what if ymax == 1? or worse 0? | |