Nothing tells the SMC that a power off or restart was user requested, so
the T2 keeps rebooting the machine thinking the system is wedged.
Approved-by: ngie (co-mentor)
Details
Details
- Reviewers
adrian ngie - Group Reviewers
drivers - Commits
- rG4ce90d56a853: asmc: notify the SMC of shutdown and restart
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 78786 Build 75669: arc lint + arc unit
Event Timeline
Comment Actions
Would this also fix the "your system was restarted due to a problem?" issue I frequently see booting up macOS after rebooting cleanly from FreeBSD?
Comment Actions
Approved; please add a Tested section listing some of the hardware you tested it on and what happened before/after.
Comment Actions
@ngie , yes, this is the goal this diff. When a restart is not clean MacOS will report the error.
In Mac Mini, when the power off is not asserted, the machine is repowered on after few minutes.
@adrian , this is tested in every hardware 2006-2020. And verified with Meridian (The boot-loader will report that the init is not clean).
Comment Actions
@ngie , yes, this is the goal this diff. When a restart is not clean MacOS will report the error.
In Mac Mini, when the power off is not asserted, the machine is repowered on after few minutes.
Yikes! Great catch.
I wonder if T1.2 needs the same or similar treatment.
Approved-by: ngie (co-mentor)
Comment Actions
I wonder if T1.2 needs the same or similar treatment.
This affects the SMC not the T1/T2 chip.
The "your system was restarted due to a problem" is an OS level check.
in my 2015 with OpenCore and updated OS, i used to get this error.
With stock i don't.