ixgbe: Guard E610 ldo function
ClosedPublic
Actions

Authored by kbowling on Mon, Nov 2, 5:58 PM.

Project Tags

None

Referenced Files

	F177503336: D61144.1794578428.diff
	Thu, Nov 12, 2:00 PM

	F177501589: D61144.1794574347.diff
	Thu, Nov 12, 12:52 PM

	F177501573: D61144.1794574287.diff
	Thu, Nov 12, 12:51 PM

	F177501538: D61144.1794574168.diff
	Thu, Nov 12, 12:49 PM

Subscribers

imp

Details

Reviewers

kgalazka

Group Reviewers

Intel Networking
Restricted Owners Package	(Owns No Changed Paths)

Commits

rG2c6b01416f80: ixgbe: Guard E610 Link Default Override access

Summary

7868958f5c79eb986d067e02ca8239aa7491dfac causes X520 (and probably all !E610) to hang on init, checking an uninitialized mutex.

Guard ldo to E610.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kbowling created this revision.Mon, Nov 2, 5:58 PM

Owners added a reviewer: Restricted Owners Package.Mon, Nov 2, 5:58 PM

Herald added subscribers: ae, imp. · View Herald TranscriptMon, Nov 2, 5:58 PM

kbowling requested review of this revision.Mon, Nov 2, 5:58 PM

Ouch :( my apologies for this oversight. ixgbe_apply_ldo_link_state is guarded by !sc->ldo_valid so it should be fine.

BTW, what do you think about using feat_cap/feat_en instead of a MAC type? I can send a follow-up patch.

This revision is now accepted and ready to land.Tue, Nov 3, 9:17 PM

In D61144#1402380, @kgalazka wrote:

Ouch :( my apologies for this oversight. ixgbe_apply_ldo_link_state is guarded by !sc->ldo_valid so it should be fine.

BTW, what do you think about using feat_cap/feat_en instead of a MAC type? I can send a follow-up patch.

Sure go ahead

Closed by commit rG2c6b01416f80: ixgbe: Guard E610 Link Default Override access. · Explain WhyWed, Nov 4, 4:59 PM

This revision was automatically updated to reflect the committed changes.

Restricted Repository Identity added a commit: rG2c6b01416f80: ixgbe: Guard E610 Link Default Override access.