Negative-sense sysctls can be confusing -- i.e., enable the disable sysctl to avoid idling CPUs upon suspend. That said, this sysctl is configuring the system to do something undesired/unusual, so I do like having 0 be the normal state. What about calling it something like "suspend_idle_workaround"?

Other than that comment seems reasonable

Negative-sense sysctls can be confusing -- i.e., enable the disable sysctl to avoid idling CPUs upon suspend.

Yeah but that's enabling a workaround that does something extra that wouldn't be done otherwise (i.e. explicitly disabling idle on suspend).

That said, this sysctl is configuring the system to do something undesired/unusual, so I do like having 0 be the normal state. What about calling it something like "suspend_idle_workaround"?

I find suspend_idle_workaround to be confusing as it doesn't really describe what this is doing, and might be confused with something relating to suspend-to-idle. I do like the current name but open to other suggestions

In that case what about just "idle_on_suspend" (or "enable_idle_on_suspend") with a default of 1

Idle on suspend sounds good to me iiuc