ckdint.h: fix cross-build with older toolchains
Needs ReviewPublic
Actions

Authored by ngie on Fri, Oct 9, 9:15 PM.

Tags

None

Referenced Files

	F175412760: D60555.id189298.diff
	Sat, Oct 10, 4:41 PM

	F175401808: D60555.id189298.diff
	Sat, Oct 10, 2:43 PM

	F175375691: D60555.diff
	Sat, Oct 10, 9:45 AM

	F175324596: D60555.id189298.diff
	Fri, Oct 9, 11:43 PM

	F175324056: D60555.diff
	Fri, Oct 9, 11:35 PM

	F175317500: D60555.id189298.diff
	Fri, Oct 9, 10:12 PM

	F175316455: D60555.diff
	Fri, Oct 9, 9:59 PM

Subscribers

imp

seuros

Details

Reviewers

des
markj

Summary

Older toolchains used in GHA fail the __GNUC_PREREQ__ tests because
the macro is not defined. Check that the macro is defined before
testing with it to address a -Wundef warning from clang.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77922
Build 74805: arc lint + arc unit

Event Timeline

ngie created this revision.Fri, Oct 9, 9:15 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 9, 9:15 PM

ngie requested review of this revision.Fri, Oct 9, 9:15 PM

Harbormaster completed remote builds in B77922: Diff 189298.Fri, Oct 9, 9:15 PM

ngie added reviewers: des, markj.Fri, Oct 9, 9:15 PM

ngie edited the summary of this revision. (Show Details)

Oddly enough this doesn't fail 100% of the time with our GHA workflows. I don't know why...
I found this issue when reviewing one of @seuros' commits: https://github.com/freebsd/freebsd-src/actions/runs/37836150968/job/113513585413 .

Revision Contents
Changeset List

Path

Size

sys/

ckdint.h

9 lines

Diff 189298

View Options

ckdint.h: fix cross-build with older toolchainsNeeds ReviewPublicActions