rtld.c: avoid double-free on dso load failure in do_load_object()
ClosedPublic
Actions

Authored by kib on Tue, Oct 6, 8:27 AM.

Tags

None

Referenced Files

	F175354755: D60402.id188883.diff
	Sat, Oct 10, 6:01 AM

	F175354517: D60402.id188851.diff
	Sat, Oct 10, 5:59 AM

	F175279500: D60402.id188851.diff
	Fri, Oct 9, 4:08 PM

	F175260505: D60402.diff
	Fri, Oct 9, 12:49 PM

	Unknown Object (File)
	Thu, Oct 8, 10:39 AM

	Unknown Object (File)
	Thu, Oct 8, 6:31 AM

	Unknown Object (File)
	Thu, Oct 8, 12:25 AM

	Unknown Object (File)
	Thu, Oct 8, 12:23 AM

View All 19 Files

Subscribers

bdragon

imp

Details

Reviewers

emaste
markj

Commits

rG274236ed084a: rtld.c: avoid double-free on dso load failure in do_load_object()

Summary

The obj->path is assigned directly from the path argument, and
load_object() frees the path on do_load_object() failure.  Do not free
it in obj_free() on the error path.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Tue, Oct 6, 8:27 AM

Herald added subscribers: bdragon, imp. · View Herald TranscriptTue, Oct 6, 8:27 AM

kib requested review of this revision.Tue, Oct 6, 8:27 AM

markj accepted this revision.Tue, Oct 6, 1:25 PM

This revision is now accepted and ready to land.Tue, Oct 6, 1:25 PM

Closed by commit rG274236ed084a: rtld.c: avoid double-free on dso load failure in do_load_object() (authored by kib). · Explain WhyTue, Oct 6, 5:34 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG274236ed084a: rtld.c: avoid double-free on dso load failure in do_load_object().

Revision Contents
Changeset List

Path

Size

libexec/

rtld-elf/

rtld.c

1 line

Diff 188883

View Options

rtld.c: avoid double-free on dso load failure in do_load_object()ClosedPublicActions