linux: Initialize per-VNET state earlier
AcceptedPublic
Actions

Authored by markj on Mon, Oct 5, 10:14 PM.

Details

Reviewers

pouria
glebius

Group Reviewers

network

Summary

Make sure that linux_ifnet_departure() can't run after
linux_ifnet_vnet_uninit() has destroyed the per-VNET unit number
allocator. Otherwise, when ifc_detach_cloner() destroys instances of an
interface type, it might be running too late. Most cloner-based drivers
tear themselves down during SI_SUB_PSEUDO or SI_SUB_PROTO_IF.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77745
Build 74628: arc lint + arc unit

Event Timeline

markj created this revision.Mon, Oct 5, 10:14 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Oct 5, 10:14 PM

Harbormaster completed remote builds in B77745: Diff 188763.Mon, Oct 5, 10:14 PM

markj requested review of this revision.Mon, Oct 5, 10:14 PM

markj added a parent revision: D60388: epair: Make vnet_epair_uninit() run earlier.

I was trying to do the same thing with PROTO_IF + SI_ORDER_FIRST on VNET_SYSUNINIT. But this version looks better to me. of course it depends on if_epair.

This revision is now accepted and ready to land.Tue, Oct 6, 3:06 PM

glebius accepted this revision.Tue, Oct 6, 4:37 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

linux_if.c

4 lines

Diff 188763

View Options

sys/compat/linux/linux_if.c

linux: Initialize per-VNET state earlierAcceptedPublicActions