Page MenuHomeFreeBSD
Differential D60258

dhclient: export the Captive Portal URI to the script
Needs ReviewPublic
Actions

Authored by bapt on Fri, Oct 2, 8:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 11, 9:59 AM
Unknown Object (File)
Sun, Oct 11, 5:35 AM
Unknown Object (File)
Sat, Oct 10, 9:04 AM
Unknown Object (File)
Fri, Oct 9, 9:13 AM
Unknown Object (File)
Fri, Oct 9, 6:32 AM
Unknown Object (File)
Fri, Oct 9, 4:33 AM
Unknown Object (File)
Thu, Oct 8, 1:13 PM
Unknown Object (File)
Thu, Oct 8, 8:21 AM
View All 36 Files
Subscribers
imp

Details

Reviewers
emaste

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77663
Build 74546: arc lint + arc unit

Event Timeline

bapt created this revision.Fri, Oct 2, 8:13 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 2, 8:13 PM
bapt requested review of this revision.Fri, Oct 2, 8:13 PM
Harbormaster completed remote builds in B77663: Diff 188494.Fri, Oct 2, 8:13 PM
bapt added a parent revision: D60257: dhclient: request the Captive Portal options.Fri, Oct 2, 8:13 PM
bapt added a child revision: D60259: dhclient-script: store the Captive Portal URI.
bapt added a reviewer: emaste.Fri, Oct 2, 8:15 PM
emaste added a comment.Fri, Oct 2, 9:08 PM

Why does this one need special handling? Worth a comment in the code / commit message.

bapt added a comment.Fri, Oct 2, 9:20 PM

to name is captive_portal_url instead of captive_portal but yes I can add a comment in the code imho more than in the commit log

bapt updated this revision to Diff 188508.Fri, Oct 2, 9:39 PM

add comment in code and commit log

Harbormaster completed remote builds in B77676: Diff 188508.Fri, Oct 2, 9:39 PM

Revision Contents
Changeset List

PathSize
sbin/
dhclient/
10 lines

Diff 188494

View Options

sbin/dhclient/dhclient.c

Loading...