Paths

Table of Contentst

Differential D60185

hwpmc: count each AMD PMC interrupt once
ClosedPublic
Actions

Authored by afscoelho_gmail.com on Wed, Sep 30, 9:09 PM.

Tags

None

Referenced Files

	F174667486: D60185.diff
	Mon, Oct 5, 1:55 AM

	F174659026: D60185.id188312.diff
	Mon, Oct 5, 12:43 AM

	F174656093: D60185.id188395.diff
	Mon, Oct 5, 12:16 AM

	F174608553: D60185.diff
	Sun, Oct 4, 3:43 PM

	Unknown Object (File)
	Sun, Oct 4, 1:02 AM

	Unknown Object (File)
	Sun, Oct 4, 12:59 AM

	Unknown Object (File)
	Sat, Oct 3, 10:07 AM

	Unknown Object (File)
	Sat, Oct 3, 6:01 AM

View All 19 Files

Subscribers

Details

Reviewers

mhorne
ali_mashtizadeh.com
gnn

Group Reviewers

Commits

rGc97cea955f90: hwpmc: count each AMD PMC interrupt once

Summary

amd_intr() and amd_intr_v2() call pmc_ibs_intr() and then update
kern.hwpmc.stats.intr_processed or intr_ignored. pmc_ibs_intr() also
updated them. So each core PMC NMI was also counted as ignored, and
each IBS NMI was counted as processed two times.

Update the statistics only in the caller.

Fixes: e51ef8ae490f ("hwpmc: Initial support for AMD IBS")
Sponsored by: AMD

Test Plan

Run any sampling session, e.g. pmcstat -S instructions or -S ibs-op,
then read kern.hwpmc.stats.intr_processed and intr_ignored.

Before: intr_ignored == intr_processed.
After: intr_ignored stays 0.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77562
Build 74445: arc lint + arc unit

Event Timeline

afscoelho_gmail.com created this revision.Wed, Sep 30, 9:09 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Sep 30, 9:09 PM

afscoelho_gmail.com requested review of this revision.Wed, Sep 30, 9:09 PM

Harbormaster completed remote builds in B77562: Diff 188267.Wed, Sep 30, 9:09 PM

mhorne accepted this revision.Thu, Oct 1, 12:57 PM

mhorne added inline comments.

sys/dev/hwpmc/hwpmc_ibs.c
700	This is also mirrored in `amd_intr()` and can be dropped. (Only affects debug builds).
748	Same here.

This revision is now accepted and ready to land.Thu, Oct 1, 12:57 PM

Remove duplicate debug messages.

This revision now requires review to proceed.Thu, Oct 1, 1:30 PM

Harbormaster completed remote builds in B77578: Diff 188312.Thu, Oct 1, 1:30 PM

Thanks for the review

ali_mashtizadeh.com accepted this revision.Thu, Oct 1, 3:41 PM

This revision is now accepted and ready to land.Thu, Oct 1, 3:41 PM

Closed by commit rGc97cea955f90: hwpmc: count each AMD PMC interrupt once (authored by afscoelho_gmail.com, committed by mhorne). · Explain WhyFri, Oct 2, 1:59 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rGc97cea955f90: hwpmc: count each AMD PMC interrupt once.

afscoelho_gmail.com mentioned this in D57630: sys: hwpmc PMU group/multiplex ABI additions.Fri, Oct 2, 6:38 PM

afscoelho_gmail.com mentioned this in D59358: hwpmc: add a group-inherit-miss log record.

afscoelho_gmail.com mentioned this in D57631: hwpmc: add PMU event/group structures and rotation runtime.

afscoelho_gmail.com mentioned this in D59359: hwpmc: multiplex system-mode groups per CPU.

afscoelho_gmail.com mentioned this in D57632: hwpmc: add PMU assigner and AMD Zen constraint provider.

afscoelho_gmail.com mentioned this in D59360: hwpmc: snapshot grouped counter values and run time.

afscoelho_gmail.com mentioned this in D59361: kern: run the PMC context-switch-in hook in fork_exit.

afscoelho_gmail.com mentioned this in D57635: libpmc: group allocation/commit API and scaled read.

afscoelho_gmail.com mentioned this in D59362: libpmc: decode the group-inherit-miss log record.

afscoelho_gmail.com mentioned this in D57636: libpmcstat: parse {a,b,c} brace-list event group syntax.

afscoelho_gmail.com mentioned this in D57637: pmcstat(8): add -b batch-grouping flag.

afscoelho_gmail.com mentioned this in D59363: pmcstat(8): warn about unfittable grouped sample periods.

afscoelho_gmail.com mentioned this in D59364: pmc(8): zero-initialize the event descriptor in stat mode.

afscoelho_gmail.com mentioned this in D59365: pmc, pmcstat: document PMU event grouping.

afscoelho_gmail.com mentioned this in D57638: tools/regression/pmc: hwpmc grouping regression test.

afscoelho_gmail.com mentioned this in D57639: tools/regression/pmc: hwpmc multiplex rejection test.

afscoelho_gmail.com mentioned this in D57640: tools/regression/pmc: hwpmc multiplex positive-path test.

afscoelho_gmail.com mentioned this in D57641: tools/regression/pmc: libpmcstat group-parser unit test.

afscoelho_gmail.com mentioned this in D59366: tools/regression/pmc: test multiplex drain and rotation.

afscoelho_gmail.com mentioned this in D59367: tools/regression/pmc: fuzz the group syscalls.

afscoelho_gmail.com mentioned this in D59368: tools/regression/pmc: test pmcstat grouping end to end.

afscoelho_gmail.com mentioned this in D59369: tools/regression/pmc: test inherit-miss logging.

afscoelho_gmail.com mentioned this in D59370: hwpmc: add deterministic PMU group test controls.

afscoelho_gmail.com mentioned this in D59371: tests: cover PMC group lifecycle and snapshots.

afscoelho_gmail.com mentioned this in D59372: tests: cover PMU group inheritance across fork.

afscoelho_gmail.com mentioned this in D59373: tests: cover PMU group authorization across exec.

afscoelho_gmail.com mentioned this in D59374: tests: cover grouped sampling residuals.

afscoelho_gmail.com mentioned this in D59375: tests: cover system-mode PMC group placement.

afscoelho_gmail.com mentioned this in D59376: tests: cover system-mode grouped sampling.

afscoelho_gmail.com mentioned this in D60186: hwpmc: keep all samples when a log is closed.Fri, Oct 2, 6:41 PM

afscoelho_gmail.com mentioned this in D60187: hwpmc: load a started PMC on threads that already run.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hwpmc/

7 lines

Diff 188267

sys/dev/hwpmc/hwpmc_ibs.c

Loading...