Page MenuHomeFreeBSD
Differential D59573

if_bnxt: add support for SIOCGI2CPB page/bank i2c requests
ClosedPublic
Actions

Authored by sumit.saxena_broadcom.com on Sep 10 2026, 2:40 PM.
Tags
None
Referenced Files
F175849446: D59573.id186387.diff
Tue, Oct 13, 9:07 PM
Unknown Object (File)
Mon, Oct 12, 3:43 PM
Unknown Object (File)
Mon, Oct 12, 3:34 PM
Unknown Object (File)
Mon, Oct 12, 3:26 PM
Unknown Object (File)
Mon, Oct 12, 1:16 PM
Unknown Object (File)
Mon, Oct 12, 10:55 AM
Unknown Object (File)
Mon, Oct 12, 3:36 AM
Unknown Object (File)
Sun, Oct 11, 4:23 PM
View All 28 Files
Subscribers
imp

Details

Reviewers
gallatin
sreekanth.reddy_broadcom.com
shurd
Commits
rGfdab50f6f810: if_bnxt: add support for SIOCGI2CPB page/bank i2c requests
Summary

Advertise IFLIB_I2C_PAGE_BANK and forward the requested page/bank to
firmware, so CMIS optics can be read correctly instead of falling
back to bogus legacy SFF-8472 decoding. Also fix bnxt_i2c_req() to
return positive errno values.

Signed-off-by: gallatin@netflix.com

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sumit.saxena_broadcom.com created this revision.Sep 10 2026, 2:40 PM
Herald added a reviewer: shurd. · View Herald TranscriptSep 10 2026, 2:40 PM
sumit.saxena_broadcom.com requested review of this revision.Sep 10 2026, 2:40 PM
gallatin added inline comments.Sep 10 2026, 2:55 PM
sys/dev/bnxt/bnxt_en/if_bnxt.c
5143

This one line is plenty. Please delete the rest of the comment

5152–5160

Seems more like a review from an llm than a code comment. Please shorten it to one line or remove it.

sumit.saxena_broadcom.com added inline comments.Sep 10 2026, 2:59 PM
sys/dev/bnxt/bnxt_en/if_bnxt.c
5143

Ack

5152–5160

Ack

sumit.saxena_broadcom.com updated this revision to Diff 187969.Tue, Sep 29, 9:29 AM

Trim down the comments.

gallatin accepted this revision.Tue, Sep 29, 4:44 PM
This revision is now accepted and ready to land.Tue, Sep 29, 4:44 PM
Closed by commit rGfdab50f6f810: if_bnxt: add support for SIOCGI2CPB page/bank i2c requests (authored by sumit.saxena_broadcom.com). · Explain WhyFri, Oct 9, 10:14 AM
This revision was automatically updated to reflect the committed changes.
sumit.saxena_broadcom.com added a commit: rGfdab50f6f810: if_bnxt: add support for SIOCGI2CPB page/bank i2c requests.
Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 9, 10:14 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
bnxt/
bnxt_en/
30 lines

Diff 187969

View Options

sys/dev/bnxt/bnxt_en/if_bnxt.c

Loading...