Page MenuHomeFreeBSD
Differential D59896

libproc: add LoongArch support
AcceptedPublic
Actions

Authored by zhaoxiaoqiang007_gmail.com on Tue, Sep 22, 2:24 PM.
Tags
None
Referenced Files
F174679268: D59896.id188511.diff
Mon, Oct 5, 3:43 AM
Unknown Object (File)
Sun, Oct 4, 6:36 PM
Unknown Object (File)
Sun, Oct 4, 3:33 PM
Unknown Object (File)
Sat, Oct 3, 3:09 PM
Unknown Object (File)
Sat, Oct 3, 5:53 AM
Unknown Object (File)
Fri, Oct 2, 11:18 AM
Unknown Object (File)
Fri, Oct 2, 6:54 AM
Unknown Object (File)
Thu, Oct 1, 10:49 PM
View All 41 Files
Subscribers
gehaowu_bitmoe.com
imp
shipujin.t_gmail.com
zishun.yi.dev_gmail.com

Details

Reviewers
jkoshy
shipujin.t_gmail.com
zishun.yi.dev_gmail.com
imp
Summary

Add the LoongArch breakpoint instruction.

Signed-off-by: Xiaoqiang Zhao <zhaoxiaoqiang007@gmail.com>
Signed-off-by: yu shan wei <mpysw@vip.163.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77372
Build 74255: arc lint + arc unit

Event Timeline

zhaoxiaoqiang007_gmail.com created this revision.Tue, Sep 22, 2:24 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Sep 22, 2:24 PM
zhaoxiaoqiang007_gmail.com requested review of this revision.Tue, Sep 22, 2:24 PM
Harbormaster completed remote builds in B77176: Diff 187414.Tue, Sep 22, 2:24 PM
zhaoxiaoqiang007_gmail.com added a parent revision: D59895: lib/msun: add LoongArch support.Tue, Sep 22, 2:25 PM
zhaoxiaoqiang007_gmail.com added a child revision: D59897: rtld: add LoongArch support.
zishun.yi.dev_gmail.com added a subscriber: zishun.yi.dev_gmail.com.Tue, Sep 22, 2:42 PM
zishun.yi.dev_gmail.com added a comment.Tue, Sep 22, 6:46 PM

Should we also update the proc_regs.c?

gehaowu_bitmoe.com added a subscriber: gehaowu_bitmoe.com.Tue, Sep 22, 8:48 PM
jkoshy added a reviewer: jkoshy.Wed, Sep 23, 8:13 AM
zhaoxiaoqiang007_gmail.com added a comment.Thu, Sep 24, 2:14 PM
In D59896#1374946, @zishun.yi.dev_gmail.com wrote:

Should we also update the proc_regs.c?

done!

shipujin.t_gmail.com added a subscriber: shipujin.t_gmail.com.Fri, Sep 25, 9:33 AM

break 0 is BRK_DEFAULT, not a user-breakpoint code, use break 0x4 (BRK_USERBP)

lib/libproc/proc_bkpt.c
66

break 0 is BRK_DEFAULT, not a user-breakpoint code, use break 0x4 (BRK_USERBP)

break 0 is the semantically unspecified default code rather than the user breakpoint code — the code_break is a semantic argument reserved for the handler (LoongArch Reference Manual Vol.1 §2.2.10.2), and the ecosystem has already assigned 0=DEFAULT, 4=BRK_USERBP "User bp (used by debuggers)", and 5=BRK_SSTEPBP. Therefore the user breakpoint should use the dedicated 0x4(the encoding has been verified by llvm-mc: break → [0x04,0x00,0x2a,0x00] = 0x002a0004).

Suggested change to:

#define	BREAKPOINT_INSTR	0x002a0004	/* break 0x4 (BRK_USERBP) */
zhaoxiaoqiang007_gmail.com updated this revision to Diff 187786.Sun, Sep 27, 1:32 AM

add missing reg value set/get
use break 0x4 for user break point

Harbormaster completed remote builds in B77372: Diff 187786.Sun, Sep 27, 1:32 AM
zhaoxiaoqiang007_gmail.com marked an inline comment as done.Sun, Sep 27, 1:37 AM
zhaoxiaoqiang007_gmail.com edited the summary of this revision. (Show Details)Sun, Sep 27, 1:40 AM
zhaoxiaoqiang007_gmail.com added reviewers: shipujin.t_gmail.com, zishun.yi.dev_gmail.com.
shipujin.t_gmail.com added a comment.Sun, Sep 27, 6:31 AM

LGTM.

zhaoxiaoqiang007_gmail.com updated this revision to Diff 188511.Sat, Oct 3, 1:39 AM

match kernel register rename

Harbormaster completed remote builds in B77678: Diff 188511.Sat, Oct 3, 1:39 AM
imp accepted this revision.Sun, Oct 4, 4:49 AM
This revision is now accepted and ready to land.Sun, Oct 4, 4:49 AM

Revision Contents
Changeset List

PathSize
lib/
libproc/
3 lines
8 lines

Diff 187786

View Options

lib/libproc/proc_bkpt.c

Loading...
View Options

lib/libproc/proc_regs.c

Loading...