Page MenuHomeFreeBSD

opencrypto: avoid false KMSAN reports
AcceptedPublic

Authored by chs on Thu, Sep 24, 12:10 AM.
Tags
None
Referenced Files
F174306007: D59959.diff
Fri, Oct 2, 5:40 AM
F174283052: D59959.diff
Fri, Oct 2, 12:35 AM
Unknown Object (File)
Thu, Oct 1, 3:59 AM
Unknown Object (File)
Wed, Sep 30, 10:26 PM
Unknown Object (File)
Wed, Sep 30, 3:40 PM
Unknown Object (File)
Wed, Sep 30, 9:29 AM
Unknown Object (File)
Tue, Sep 29, 11:28 PM
Unknown Object (File)
Tue, Sep 29, 8:00 PM
Subscribers

Details

Reviewers
imp
jhb
Summary

In crypto_copyback(), the memory we're copying is always initialized
but sometimes the initialization is done in asm routines, so KMSAN
is not aware that the memory has been initialized.
Mark this memory initialized explicitly to avoid false KMSAN reports.
Found with KMSAN.

Sponsored by: Netflix
Assisted-By: Claude Code - Opus 5 (1M context)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77243
Build 74126: arc lint + arc unit

Event Timeline

chs requested review of this revision.Thu, Sep 24, 12:10 AM
chs created this revision.
This revision is now accepted and ready to land.Tue, Sep 29, 10:31 PM

This is a pretty heavy hammer, might it not hide legitimate bugs? Why not fix the drivers directly?