Add the LoongArch breakpoint instruction.
Signed-off-by: Xiaoqiang Zhao <zhaoxiaoqiang007@gmail.com>
Signed-off-by: yu shan wei <mpysw@vip.163.com>
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 77176 Build 74059: arc lint + arc unit
Event Timeline
Comment Actions
break 0 is BRK_DEFAULT, not a user-breakpoint code, use break 0x4 (BRK_USERBP)
| lib/libproc/proc_bkpt.c | ||
|---|---|---|
| 63 | break 0 is BRK_DEFAULT, not a user-breakpoint code, use break 0x4 (BRK_USERBP) break 0 is the semantically unspecified default code rather than the user breakpoint code — the code_break is a semantic argument reserved for the handler (LoongArch Reference Manual Vol.1 §2.2.10.2), and the ecosystem has already assigned 0=DEFAULT, 4=BRK_USERBP "User bp (used by debuggers)", and 5=BRK_SSTEPBP. Therefore the user breakpoint should use the dedicated 0x4(the encoding has been verified by llvm-mc: break → [0x04,0x00,0x2a,0x00] = 0x002a0004). Suggested change to: #define BREAKPOINT_INSTR 0x002a0004 /* break 0x4 (BRK_USERBP) */ | |