Differential D59887

sysctl: Return ECAPMODE when trying to access sysctls in capability mode
ClosedPublic
Actions

Authored by markj on Tue, Sep 22, 2:01 PM.

Details

Reviewers

emaste

Group Reviewers

capsicum

Commits

rGa76e986470f8: sysctl: Return ECAPMODE when trying to access sysctls in capability mode

Summary

We have always returned EPERM in this case, but it seems incorrect.
Fix the errno value.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77164
Build 74047: arc lint + arc unit

Event Timeline

markj created this revision.Tue, Sep 22, 2:01 PM

Herald added subscribers: olce, imp. · View Herald TranscriptTue, Sep 22, 2:01 PM

markj requested review of this revision.Tue, Sep 22, 2:01 PM

markj added a child revision: D59888: exec: Remove an unneeded capability mode check.

Harbormaster completed remote builds in B77164: Diff 187401.Tue, Sep 22, 2:01 PM

From rG:ff66f6a404282, early days. Please update sysctl(3) to reference the errno.

Update sysctl.3.

Herald added a subscriber: ziaee. · View Herald TranscriptTue, Sep 22, 2:26 PM

Harbormaster completed remote builds in B77183: Diff 187421.Tue, Sep 22, 2:26 PM

emaste accepted this revision.Tue, Sep 22, 2:40 PM

This revision is now accepted and ready to land.Tue, Sep 22, 2:40 PM

Closed by commit rGa76e986470f8: sysctl: Return ECAPMODE when trying to access sysctls in capability mode (authored by markj). · Explain WhyTue, Sep 29, 1:30 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGa76e986470f8: sysctl: Return ECAPMODE when trying to access sysctls in capability mode.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_sysctl.c

2 lines

Diff 187401

View Options

sysctl: Return ECAPMODE when trying to access sysctls in capability modeClosedPublicActions