Page MenuHomeFreeBSD
Differential D59844

virtual_oss(8): Fix cuse.ko check
Needs ReviewPublic
Actions

Authored by fernape on Sat, Sep 19, 4:43 PM.
Tags
None
Referenced Files
F172756685: D59844.diff
Sun, Sep 20, 7:01 PM
F172681179: D59844.id187239.diff
Sun, Sep 20, 4:30 AM
F172680881: D59844.diff
Sun, Sep 20, 4:27 AM
Unknown Object (File)
Sun, Sep 20, 12:33 AM
Unknown Object (File)
Sun, Sep 20, 12:29 AM
Unknown Object (File)
Sat, Sep 19, 8:58 PM
Subscribers
imp

Details

Reviewers
christos
Group Reviewers
audio
Summary

There is no need at all to load the cuse module to just access the tool help.

kldload always checks for permissions first returning -EPERM if the user can't
load modules and -EEXIST if the user can, but the module is already loaded.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77093
Build 73976: arc lint + arc unit

Event Timeline

fernape created this revision.Sat, Sep 19, 4:43 PM
Herald added a subscriber: imp. · View Herald TranscriptSat, Sep 19, 4:43 PM
Harbormaster completed remote builds in B77093: Diff 187239.Sat, Sep 19, 4:43 PM
fernape requested review of this revision.Sat, Sep 19, 4:43 PM
fernape added reviewers: audio, christos.Sat, Sep 19, 4:44 PM
fernape mentioned this in D59621: virtual_oss(8): Fix cuse.ko check.Sat, Sep 19, 4:47 PM
christos added inline comments.Sun, Sep 20, 3:17 PM
usr.sbin/virtual_oss/virtual_oss/main.c
2588

The function name makes it obvious what the code is doing, the comment is redundant.

2590
2593

Also redundant.

fernape updated this revision to Diff 187283.Sun, Sep 20, 4:24 PM

Remove comments

Harbormaster completed remote builds in B77119: Diff 187283.Sun, Sep 20, 4:24 PM
christos accepted this revision.Sun, Sep 20, 4:25 PM

LGTM, but don't commit it until we have resolved the discussion in D59621.

This revision is now accepted and ready to land.Sun, Sep 20, 4:25 PM
fernape updated this revision to Diff 187284.Sun, Sep 20, 4:25 PM

Reuse variable in error message.

This revision now requires review to proceed.Sun, Sep 20, 4:25 PM
Harbormaster completed remote builds in B77120: Diff 187284.Sun, Sep 20, 4:25 PM
fernape marked 2 inline comments as done.Sun, Sep 20, 4:25 PM
fernape added inline comments.
usr.sbin/virtual_oss/virtual_oss/main.c
2588

Not really. See obiwac comment about it in https://reviews.freebsd.org/D59621

christos added inline comments.Sun, Sep 20, 4:26 PM
usr.sbin/virtual_oss/virtual_oss/main.c
2588

Minor nit: this could be part of the if above with an additional &&.

fernape updated this revision to Diff 187297.Sun, Sep 20, 6:18 PM

Use one single if statement.

Harbormaster completed remote builds in B77123: Diff 187297.Sun, Sep 20, 6:18 PM
fernape marked an inline comment as done.Sun, Sep 20, 6:19 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
virtual_oss/
virtual_oss/
9 lines

Diff 187239

View Options

usr.sbin/virtual_oss/virtual_oss/main.c

Loading...