Page MenuHomeFreeBSD
Differential D59776

sysutils/cni-dnsname: Fix arm64 build
ClosedPublic
Actions

Authored by dch on Thu, Sep 17, 9:45 PM.
Tags
None
Referenced Files
F174173658: D59776.id187001.diff
Thu, Oct 1, 3:39 AM
F174166468: D59776.id.diff
Thu, Oct 1, 2:12 AM
F174128881: D59776.id.diff
Wed, Sep 30, 7:38 PM
F174112400: D59776.id187001.diff
Wed, Sep 30, 5:23 PM
Unknown Object (File)
Wed, Sep 30, 4:58 AM
Unknown Object (File)
Tue, Sep 29, 7:04 PM
Unknown Object (File)
Tue, Sep 29, 8:28 AM
Unknown Object (File)
Sun, Sep 27, 6:01 PM
View All 27 Files
Subscribers
emaste

Details

Reviewers
andrew
adrian
emaste
Commits
R11:3aea56ee2920: sysutils/cni-dnsname: Fix arm64 build
Summary

golang.org/x/sys/unix fails to build on aarch64 because the pinned vendored
FpReg references an undefined uint128 type, at least on FreeBSD arm64:

vendor/golang.org/x/sys/unix/ztypes_freebsd_arm64.go:400:12: undefined: uint128

Fake it with an equivalent 16x byte array, which is what upstream now does:

https://github.com/golang/go/blob/master/src/cmd/vendor/golang.org/x/sys/unix/ztypes_freebsd_arm64.go#L337-L342

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77042
Build 73925: arc lint + arc unit

Event Timeline

dch created this revision.Thu, Sep 17, 9:45 PM
Herald added a reviewer: andrew. · View Herald TranscriptThu, Sep 17, 9:45 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a subscriber: emaste. · View Herald Transcript
dch requested review of this revision.Thu, Sep 17, 9:45 PM
Harbormaster completed remote builds in B77041: Diff 187001.Thu, Sep 17, 9:45 PM
dch added a reviewer: adrian.Thu, Sep 17, 9:47 PM

Not sure if this needs a PORTREVISION bump, it should be arch independent (because of the path)

dch updated this revision to Diff 187002.Thu, Sep 17, 9:57 PM

Regenerate patch without preceding text

Harbormaster completed remote builds in B77042: Diff 187002.Thu, Sep 17, 9:57 PM
dch edited the summary of this revision. (Show Details)Thu, Sep 17, 9:58 PM
emaste accepted this revision.Fri, Sep 18, 1:53 PM

If it didn't build before on arm64 and the patch does not affect !amd64 I imagine a bump is unnecessary

This revision is now accepted and ready to land.Fri, Sep 18, 1:53 PM
adrian accepted this revision.Fri, Sep 18, 3:27 PM

rofl i love it.

ty for catching it!

Closed by commit R11:3aea56ee2920: sysutils/cni-dnsname: Fix arm64 build (authored by dch). · Explain WhyMon, Sep 28, 10:42 AM
This revision was automatically updated to reflect the committed changes.
dch added a commit: R11:3aea56ee2920: sysutils/cni-dnsname: Fix arm64 build.

Revision Contents
Changeset List

PathSize
sysutils/
cni-dnsname/
files/
11 lines

Diff 187002

View Options

sysutils/cni-dnsname/files/patch-vendor_golang.org_x_sys_unix_ztypes__freebsd__arm64.go

Loading...