Page MenuHomeFreeBSD
Differential D59602

pciconf: Add -C option to filter by class name
ClosedPublic
Actions

Authored by code_fedang.net on Fri, Sep 11, 10:16 PM.
Tags
None
Referenced Files
F175129476: D59602.id.diff
Thu, Oct 8, 12:13 PM
F175084997: D59602.id186782.diff
Thu, Oct 8, 3:59 AM
Unknown Object (File)
Fri, Oct 2, 7:03 PM
Unknown Object (File)
Fri, Oct 2, 6:54 PM
Unknown Object (File)
Fri, Oct 2, 5:15 PM
Unknown Object (File)
Fri, Oct 2, 4:37 PM
Unknown Object (File)
Thu, Oct 1, 7:32 AM
Unknown Object (File)
Tue, Sep 29, 9:40 PM
View All 74 Files
Subscribers
imp
ziaee

Details

Reviewers
bnovkov
Commits
rG46d383af0dbd: pciconf: Add -C option to filter by class name

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76936
Build 73819: arc lint + arc unit

Event Timeline

code_fedang.net created this revision.Fri, Sep 11, 10:16 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Sep 11, 10:16 PM
code_fedang.net requested review of this revision.Fri, Sep 11, 10:16 PM
Harbormaster completed remote builds in B76785: Diff 186493.Fri, Sep 11, 10:16 PM
code_fedang.net updated this revision to Diff 186494.Fri, Sep 11, 10:27 PM

Use strcasecmp instead of strcmp to check class name.

Harbormaster completed remote builds in B76786: Diff 186494.Fri, Sep 11, 10:27 PM
code_fedang.net added a comment.Fri, Sep 11, 10:29 PM

Addresses Bug 289923

bnovkov added inline comments.Mon, Sep 14, 4:44 PM
usr.sbin/pciconf/pciconf.8
26

Please bump the date.

usr.sbin/pciconf/pciconf.c
1094

This function should ideally return a bool.

1097
1100

Please turn this into an explicit == 0 check

1101–1104
code_fedang.net updated this revision to Diff 186782.Tue, Sep 15, 3:46 PM

Address comment

Harbormaster completed remote builds in B76936: Diff 186782.Tue, Sep 15, 3:46 PM
code_fedang.net marked 5 inline comments as done.Tue, Sep 15, 4:18 PM
bnovkov added inline comments.Fri, Sep 18, 9:24 AM
usr.sbin/pciconf/pciconf.c
335

Passing -l without a class string will crash the program since there's no class != NULL check here or in validate_class.

I suggest adding a NULL check in validate_class.

code_fedang.net updated this revision to Diff 187182.Fri, Sep 18, 11:20 PM

Fix null check

Harbormaster completed remote builds in B77072: Diff 187182.Fri, Sep 18, 11:20 PM
code_fedang.net marked an inline comment as done.Fri, Sep 18, 11:21 PM
code_fedang.net added inline comments.
usr.sbin/pciconf/pciconf.c
335

oops, that slipped through

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Sep 21, 6:39 PM
Closed by commit rG46d383af0dbd: pciconf: Add -C option to filter by class name (authored by code_fedang.net, committed by bnovkov). · Explain Why
This revision was automatically updated to reflect the committed changes.
bnovkov added a commit: rG46d383af0dbd: pciconf: Add -C option to filter by class name.

Revision Contents
Changeset List

PathSize
usr.sbin/
pciconf/
10 lines
40 lines

Diff 186782

View Options

usr.sbin/pciconf/pciconf.8

Loading...
View Options

usr.sbin/pciconf/pciconf.c

Loading...